Skip to content

Commit 1123e7f

Browse files
committed
[Test] Fix spec tests failures for Ubuntu24.04 and Amazon Linux 2023.
1 parent 0b41c38 commit 1123e7f

File tree

3 files changed

+36
-21
lines changed

3 files changed

+36
-21
lines changed

cookbooks/aws-parallelcluster-environment/spec/unit/resources/efa_spec.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,10 @@ def self.configure(chef_run)
5555
cached(:prerequisites) do
5656
if %(redhat rocky).include?(platform)
5757
%w(environment-modules libibverbs-utils librdmacm-utils rdma-core-devel)
58-
elsif platform == 'amazon'
58+
elsif platform == 'amazon' and version == '2'
5959
%w(environment-modules libibverbs-utils librdmacm-utils)
60+
elsif platform == 'amazon' and version == '2023'
61+
%w(environment-modules libibverbs-utils librdmacm-utils rdma-core-devel)
6062
else
6163
"environment-modules"
6264
end

cookbooks/aws-parallelcluster-environment/spec/unit/resources/network_service_spec.rb

Lines changed: 32 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,29 @@ def self.reload(chef_run)
2626
ConvergeNetworkService.restart(runner)
2727
end
2828
cached(:node) { chef_run.node }
29-
cached(:network_service_name) do
30-
{
31-
'amazon' => 'network',
32-
'centos' => 'network',
33-
'redhat' => 'NetworkManager',
34-
'rocky' => 'NetworkManager',
35-
'ubuntu' => 'systemd-resolved',
36-
}[platform]
37-
end
29+
cached(:network_service_name) {
30+
if platform == 'amazon' and version == '2' or platform == 'centos'
31+
'network'
32+
elsif platform == 'amazon' and version == '2023'
33+
'systemd-networkd'
34+
elsif platform == 'ubuntu'
35+
'systemd-resolved'
36+
elsif %(redhat rocky).include?(platform)
37+
'NetworkManager'
38+
else
39+
raise "Cannot determine network_service_name: unrecognized platform #{platform}"
40+
end
41+
}
3842

3943
it "restarts network service" do
4044
is_expected.to restart_network_service('restart')
45+
network_services_to_restart = if platform == 'amazon' and version == '2023'
46+
[network_service_name, 'systemd-resolved']
47+
else
48+
[network_service_name]
49+
end
4150

42-
is_expected.to write_log("Restarting '#{network_service_name}' service, platform #{platform} '#{node['platform_version']}'")
51+
is_expected.to write_log("Restarting '#{network_services_to_restart.join(' ')}' service, platform #{platform} '#{node['platform_version']}'")
4352

4453
is_expected.to restart_service(network_service_name)
4554
.with(ignore_failure: true)
@@ -55,15 +64,19 @@ def self.reload(chef_run)
5564
runner = runner(platform: platform, version: version, step_into: ['network_service'])
5665
ConvergeNetworkService.reload(runner)
5766
end
58-
cached(:network_service_name) do
59-
{
60-
'amazon' => 'network',
61-
'centos' => 'network',
62-
'redhat' => 'NetworkManager',
63-
'rocky' => 'NetworkManager',
64-
'ubuntu' => 'systemd-resolved',
65-
}[platform]
66-
end
67+
cached(:network_service_name) {
68+
if platform == 'amazon' and version == '2' or platform == 'centos'
69+
'network'
70+
elsif platform == 'amazon' and version == '2023'
71+
'systemd-networkd'
72+
elsif platform == 'ubuntu'
73+
'systemd-resolved'
74+
elsif %(redhat rocky).include?(platform)
75+
'NetworkManager'
76+
else
77+
raise "Cannot determine network_service_name: unrecognized platform #{platform}"
78+
end
79+
}
6780

6881
it 'reloads network_service' do
6982
is_expected.to reload_network_service('reload')

cookbooks/aws-parallelcluster-environment/spec/unit/resources/raid_mount_unmount_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def wait_for_block_dev(_path)
1111
context "on #{platform}#{version}" do
1212
cached(:venv_path) { 'venv' }
1313
cached(:raid_superblock_version) do
14-
%(redhat rocky).include?(platform) || "#{platform}#{version}" == 'ubuntu20.04' || "#{platform}#{version}" == 'ubuntu22.04' ? '1.2' : '0.90'
14+
%(redhat rocky ubuntu).include?(platform) || "#{platform}#{version}" == 'amazon2023' ? '1.2' : '0.90'
1515
end
1616
cached(:chef_run) do
1717
runner = runner(

0 commit comments

Comments
 (0)