Configure c states using grubby command

For other OSes, this commit keeps the old approach of changing grub files. This is done because the old approach does not take effect on RHEL9 and Rocky9. The `grubby` command does not take effect on some of the old OSes.

Signed-off-by: Hanwen <[email protected]>

Author: hanwen-cluster

cookbooks/aws-parallelcluster-platform/resources/c_states/c_states_redhat8.rb

@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and limitations under the License.
 
 provides :c_states, platform: 'redhat' do |node|
-  node['platform_version'].to_i >= 8
+  node['platform_version'].to_i == 8
 end
 
 use 'partial/_c_states_common'

cookbooks/aws-parallelcluster-platform/resources/c_states/c_states_redhat9.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+# Copyright:: 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License").
+# You may not use this file except in compliance with the License.
+# A copy of the License is located at
+#
+# http://aws.amazon.com/apache2.0/
+#
+# or in the "LICENSE.txt" file accompanying this file.
+# This file is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, express or implied.
+# See the License for the specific language governing permissions and limitations under the License.
+
+provides :c_states, platform: 'redhat' do |node|
+  node['platform_version'].to_i == 9
+end
+
+use 'partial/_c_states_common'
+use 'partial/_c_states_redhat_9_based'

cookbooks/aws-parallelcluster-platform/resources/c_states/c_states_rocky8.rb

@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and limitations under the License.
 
 provides :c_states, platform: 'rocky' do |node|
-  node['platform_version'].to_i >= 8
+  node['platform_version'].to_i == 8
 end
 
 use 'partial/_c_states_common'

cookbooks/aws-parallelcluster-platform/resources/c_states/c_states_rocky9.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+# Copyright:: 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License").
+# You may not use this file except in compliance with the License.
+# A copy of the License is located at
+#
+# http://aws.amazon.com/apache2.0/
+#
+# or in the "LICENSE.txt" file accompanying this file.
+# This file is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, express or implied.
+# See the License for the specific language governing permissions and limitations under the License.
+
+provides :c_states, platform: 'rocky' do |node|
+  node['platform_version'].to_i == 9
+end
+
+use 'partial/_c_states_common'
+use 'partial/_c_states_redhat_9_based'

cookbooks/aws-parallelcluster-platform/resources/c_states/partial/_c_states_redhat_9_based.rb

@@ -0,0 +1,4 @@
+action :setup do
+  return if !x86_instance? || on_docker?
+  shell_out!('grubby --update-kernel=ALL --args="intel_idle.max_cstate=1 processor.max_cstate=1"')
+end

cookbooks/aws-parallelcluster-platform/spec/unit/resources/c_states_spec.rb

@@ -11,6 +11,9 @@ def self.setup(chef_run)
 end
 
 describe 'c_states:setup' do
+  stubs_for_provider("c_states[setup]") do |provider|
+    allow(provider).to receive_shell_out("grubby --update-kernel=ALL --args=\"intel_idle.max_cstate=1 processor.max_cstate=1\"")
+  end
   before do
     stubs_for_resource('c_states') do |res|
       allow(res).to receive(:append_if_not_present_grub_cmdline)
@@ -40,16 +43,18 @@ def self.setup(chef_run)
         is_expected.to setup_c_states('setup')
       end
 
-      it 'edits /etc/default/grub' do
-        stubs_for_resource('c_states[setup]') do |res|
-          expect(res).to receive(:append_if_not_present_grub_cmdline).with(grub_cmdline_attributes, grub_variable)
+      if version.to_i != 9
+        it 'edits /etc/default/grub' do
+          stubs_for_resource('c_states[setup]') do |res|
+            expect(res).to receive(:append_if_not_present_grub_cmdline).with(grub_cmdline_attributes, grub_variable)
+          end
+          chef_run
         end
-        chef_run
-      end
 
-      it 'regenerate grub boot menus' do
-        is_expected.to run_execute('Regenerate grub boot menu')
-          .with(command: regenerate_grub_boot_menu_command)
+        it 'regenerate grub boot menus' do
+          is_expected.to run_execute('Regenerate grub boot menu')
+            .with(command: regenerate_grub_boot_menu_command)
+        end
       end
     end
 

cookbooks/aws-parallelcluster-platform/test/controls/c_states_spec.rb

@@ -9,7 +9,7 @@
     its('content') { should match(/intel_idle.max_cstate=1/) }
   end
 
-  if os.redhat? # redhat includes amazon
+  if os.redhat8? || os.alinux2? || os.centos7? || os.rocky8?
 
     describe file('/boot/grub2/grub.cfg') do
       it { should exist }
@@ -24,14 +24,6 @@
       its('content') { should match(/processor.max_cstate=1/) }
       its('content') { should match(/intel_idle.max_cstate=1/) }
     end
-
-  else
-    describe "unsupported OS" do
-      # this produces a skipped control (ignore-like)
-      # adding a new OS to kitchen platform list and running the tests,
-      # it would surface the fact this recipe does not support this OS.
-      pending "support for #{os.name}-#{os.release} needs to be implemented"
-    end
   end
 end