Remove berkshelf

Berkshelf is a dependency manager for Chef cookbooks. With it, you can depend on community cookbooks and include them in your workflow. Berkshelf is not useful when all cookbooks are local. ParallelCluster cookbook has all third party cookbooks ready locally.

Reducing software we depend on improves stability of the product. (e.g we have one known issue related to berkshelf https://github.com/aws/aws-parallelcluster/wiki/(3.8.0-%E2%80%90-3.9.3)-ParallelCluster-Build-Image-Failing-during-Installation-of-Minitar-Ruby-Gem-Dependency)

Signed-off-by: Hanwen <[email protected]>

Author: hanwen-cluster

.gitignore

@@ -2,7 +2,6 @@
 .idea
 *.iml
 .vagrant
-Berksfile.lock
 *~
 *#
 .#*

Berksfile

@@ -13,6 +13,7 @@ This file is used to list changes made in each version of the AWS ParallelCluste
 - Ubuntu 20.04 is no longer supported.
 - Upgrade Slurm to version 24.11.5.
 - Upgrade DCV to version 2024.0-19030.
+- Remove `berkshelf`. All cookbooks are local and do not need `berkshelf` dependency management.
 
 3.13.2
 ------

CHANGELOG.md

@@ -2,8 +2,6 @@
 
 source 'https://rubygems.org'
 
-gem 'berkshelf'
-
 group :style do
   gem 'cookstyle', '~> 7.25.9'
   gem 'rake', '~> 13.0.1'

Gemfile

@@ -8,9 +8,7 @@ This repo contains the AWS ParallelCluster Chef cookbook used in AWS ParallelClu
 
 # Code structure
 
-The root folder of the cookbook repository can be considered the main cookbook, since it contains two files: `Berksfile` and `metadata.rb`.
-These files are used by the CLI (build image time) and `user-data.sh` code to [vendor](https://docs.chef.io/workstation/berkshelf/#berks-vendor)
-the other sub-cookbooks and third party cookbooks.
+The root folder of the cookbook repository can be considered the main cookbook.
 
 The main cookbook does not contain any recipe, attribute or library. They are distributed in the functional cookbooks under the `cookbooks` folder
 defined as follows:
@@ -391,15 +389,6 @@ If you interrupt it and try to run `kitchen verify`, you see authentication fail
 This happens because Ubuntu22 does not accept authentication via RSA key. You need to re-create a key pair 
 using `ED25519` key type.
 
-### Known issues with Berks
-
-#### Kitchen doesn't see your changes
-
-If Kitchen doesn't detect your changes, try
-```
-berks shelf uninstall ${COOKBOOK_NAME}
-```
-
 ## About python tests
 
 Python tests are configured in `tox.ini` file, including paths to python files.

README.md

@@ -1,4 +1,3 @@
 require 'chefspec'
-require 'chefspec/berkshelf'
 
 require_relative '../../aws-parallelcluster-shared/spec/spec_helper'

cookbooks/aws-parallelcluster-awsbatch/Berksfile

@@ -1,4 +1,3 @@
 require 'chefspec'
-require 'chefspec/berkshelf'
 
 require_relative '../../aws-parallelcluster-shared/spec/spec_helper'