[Nvidia-Imex] Updating function names

Author: Himani Anil Deshpande

cookbooks/aws-parallelcluster-platform/resources/nvidia_imex/nvidia_imex_amazon2.rb

@@ -17,7 +17,7 @@
 use 'partial/_nvidia_imex_common.rb'
 use 'partial/_nvidia_imex_rhel.rb'
 
-def imex_installed
+def imex_installed?
   # We do not install NVIDIA-Imex for Alinux2 due to restriction on NVIDIA driver
   true
 end

cookbooks/aws-parallelcluster-platform/resources/nvidia_imex/partial/_nvidia_imex_common.rb

@@ -17,7 +17,7 @@
 
 action :install do
   return unless nvidia_enabled_or_installed?
-  return if on_docker? || imex_installed || aws_region.start_with?("us-iso")
+  return if on_docker? || imex_installed? || aws_region.start_with?("us-iso")
 
   # Add NVIDIA repo for nvidia-imex
   nvidia_repo 'add nvidia repository' do
@@ -60,7 +60,7 @@
 end
 
 action :configure do
-  return unless imex_installed && node['cluster']['node_type'] == "ComputeFleet"
+  return unless imex_installed? && node['cluster']['node_type'] == "ComputeFleet"
   # Start nvidia-imex on p6e-gb200 and only on ComputeFleet
   if get_nvswitch_count(get_device_ids['gb200']) > 1
     service nvidia_imex_service do
@@ -82,7 +82,7 @@ def nvidia_imex_full_version
   "#{node['cluster']['nvidia']['driver_version']}-1"
 end
 
-def imex_installed
+def imex_installed?
   ::File.exist?("/usr/bin/#{nvidia_imex_service}") || ::File.exist?("/usr/bin/#{nvidia_imex_service}-ctl")
 end
 

cookbooks/aws-parallelcluster-platform/spec/unit/resources/nvidia_imex_spec.rb

@@ -70,7 +70,7 @@ def self.configure(chef_run)
   end
 end
 
-describe 'nvidia_imex:imex_installed' do
+describe 'nvidia_imex:imex_installed?' do
   for_all_oses do |platform, version|
     context "on #{platform}#{version}" do
       cached(:chef_run) do
@@ -89,11 +89,11 @@ def self.configure(chef_run)
 
         if platform == 'amazon' && version == '2'
           it 'is true' do
-            expect(resource.imex_installed).to eq(true)
+            expect(resource.imex_installed?).to eq(true)
           end
         else
           it 'is false' do
-            expect(resource.imex_installed).to eq(false)
+            expect(resource.imex_installed?).to eq(false)
           end
         end
       end
@@ -105,7 +105,7 @@ def self.configure(chef_run)
         end
 
         it 'is true' do
-          expect(resource.imex_installed).to eq(true)
+          expect(resource.imex_installed?).to eq(true)
         end
       end
 
@@ -116,7 +116,7 @@ def self.configure(chef_run)
         end
 
         it 'is true' do
-          expect(resource.imex_installed).to eq(true)
+          expect(resource.imex_installed?).to eq(true)
         end
       end
 
@@ -127,7 +127,7 @@ def self.configure(chef_run)
         end
 
         it 'is true' do
-          expect(resource.imex_installed).to eq(true)
+          expect(resource.imex_installed?).to eq(true)
         end
       end
     end
@@ -155,7 +155,7 @@ def self.configure(chef_run)
       context 'when nvidia-imex binary already exists' do
         cached(:chef_run) do
           stubs_for_resource('nvidia_imex') do |res|
-            allow(res).to receive(:imex_installed).and_return(true)
+            allow(res).to receive(:imex_installed?).and_return(true)
           end
           runner = runner(platform: platform, version: version, step_into: ['nvidia_imex'])
           ConvergeNvidiaImex.install(runner)
@@ -273,7 +273,7 @@ def self.configure(chef_run)
       context "when nvidia-imex binary is not installed" do
         cached(:chef_run) do
           stubs_for_resource('nvidia_imex') do |res|
-            allow(res).to receive(:imex_installed).and_return(false)
+            allow(res).to receive(:imex_installed?).and_return(false)
           end
           runner = runner(platform: platform, version: version, step_into: ['nvidia_imex'])
           ConvergeNvidiaImex.configure(runner)
@@ -289,7 +289,7 @@ def self.configure(chef_run)
         context "when get_nvswitch_count > 1 on #{node_type} node" do
           cached(:chef_run) do
             stubs_for_provider('nvidia_imex[configure]') do |pro|
-              allow(pro).to receive(:imex_installed).and_return(true)
+              allow(pro).to receive(:imex_installed?).and_return(true)
               allow(pro).to receive(:get_device_ids).and_return({ 'gb200' => 'test' })
               allow(pro).to receive(:get_nvswitch_count).with('test').and_return(4)
             end
@@ -318,7 +318,7 @@ def self.configure(chef_run)
       context "when get_nvswitch_count <= 1" do
         cached(:chef_run) do
           stubs_for_provider('nvidia_imex[configure]') do |pro|
-            allow(pro).to receive(:imex_installed).and_return(true)
+            allow(pro).to receive(:imex_installed?).and_return(true)
             allow(pro).to receive(:get_device_ids).and_return({ 'gb200' => 'test' })
             allow(pro).to receive(:get_nvswitch_count).with('test').and_return(1)
           end