Merge branch 'develop' into wip/mgiacomo/fix-ad-reset-script-0602-1

Author: himani2411

cookbooks/aws-parallelcluster-computefleet/recipes/install/parallelcluster_node.rb

@@ -36,7 +36,7 @@
 if aws_region.start_with?("us-iso") && !is_custom_node?
   node_package = "aws-parallelcluster-node-#{node['cluster']['parallelcluster-node-version']}.tgz"
 
-  node.default['cluster']['custom_node_package'] = "#{node['cluster']['s3_url']}/parallelcluster/#{node['cluster']['parallelcluster-node-version']}/node/#{node_package}"
+  node.override['cluster']['custom_node_package'] = "#{node['cluster']['s3_url']}/parallelcluster/#{node['cluster']['parallelcluster-node-version']}/node/#{node_package}"
 end
 
 if is_custom_node?

cookbooks/aws-parallelcluster-environment/test/controls/nfs_spec.rb

@@ -1,21 +1,22 @@
-control 'tag:install_nfs_installed_with_right_version' do
-  title 'Check NFS process is running and installed version'
-
-  only_if { !os_properties.on_docker? }
-
-  # Check nfsd process is running
-  describe command('ps aux') do
-    its('stdout') { should match(/nfsd/) }
-  end
-
-  # Check version of NFS
-  describe "Verify installed NFS version is 4\n" do
-    nfs_version = command("rpcinfo -p localhost | awk '{print $5$2}' | grep nfs4")
-    describe nfs_version do
-      its('stdout') { should match "nfs4" }
-    end
-  end
-end
+# FIXME: Re-enabled the following check and fix failures
+# control 'tag:install_nfs_installed_with_right_version' do
+#   title 'Check NFS process is running and installed version'
+#
+#   only_if { !os_properties.on_docker? }
+#
+#   # Check nfsd process is running
+#   describe command('ps aux') do
+#     its('stdout') { should match(/nfsd/) }
+#   end
+#
+#   # Check version of NFS
+#   describe "Verify installed NFS version is 4\n" do
+#     nfs_version = command("rpcinfo -p localhost | awk '{print $5$2}' | grep nfs4")
+#     describe nfs_version do
+#       its('stdout') { should match "nfs4" }
+#     end
+#   end
+# end
 
 control 'tag:config_nfs_configured_on_head_node' do
   title 'Check that nfs is configured correctly'

cookbooks/aws-parallelcluster-slurm/recipes/install/install_pyxis.rb

@@ -15,7 +15,7 @@
 # OR CONDITIONS OF ANY KIND, express or implied. See the License for the specific language governing permissions and
 # limitations under the License.
 
-return unless nvidia_installed?
+return unless nvidia_enabled? || nvidia_installed?
 return if pyxis_installed?
 
 pyxis_version = node['cluster']['pyxis']['version']

cookbooks/aws-parallelcluster-slurm/spec/unit/recipes/install_pyxis_spec.rb

@@ -33,6 +33,7 @@
           node.override['cluster']['pyxis']['version'] = pyxis_version
           node.override['cluster']['pyxis']['runtime_path'] = pyxis_runtime_dir
         end
+        allow_any_instance_of(Object).to receive(:nvidia_enabled?).and_return(true)
         allow_any_instance_of(Object).to receive(:nvidia_installed?).and_return(true)
         allow_any_instance_of(Object).to receive(:pyxis_installed?).and_return(false)
         runner.converge(described_recipe)
@@ -93,6 +94,7 @@
           runner = runner(platform: platform, version: version) do |_node|
             RSpec::Mocks.configuration.allow_message_expectations_on_nil = true
           end
+          allow_any_instance_of(Object).to receive(:nvidia_enabled?).and_return(true)
           allow_any_instance_of(Object).to receive(:nvidia_installed?).and_return(true)
           allow_any_instance_of(Object).to receive(:pyxis_installed?).and_return(true)
           runner.converge(described_recipe)

cookbooks/aws-parallelcluster-slurm/test/controls/munge_spec.rb

@@ -47,11 +47,6 @@
     it { should exist }
     it { should be_directory }
   end
-
-  describe file('/var/run/munge') do
-    it { should exist }
-    it { should be_directory }
-  end
 end unless os_properties.redhat_on_docker?
 
 control 'tag:config_munge_service_enabled' do

cookbooks/aws-parallelcluster-slurm/test/controls/pyxis_spec.rb

@@ -10,7 +10,7 @@
 # See the License for the specific language governing permissions and limitations under the License.
 
 control 'tag:install_pyxis_installed' do
-  only_if { instance.nvidia_installed? }
+  only_if { ['yes', true, 'true'].include?(node['cluster']['nvidia']['enabled']) || instance.nvidia_installed? }
 
   title 'Checks Pyxis has been installed'