[DFSM] Address linter failures.

Signed-off-by: Giacomo Marciani <[email protected]>

Author: gmarciani

cookbooks/aws-parallelcluster-slurm/libraries/dynamo.rb

@@ -15,11 +15,10 @@
 # the instance id and the cluster config version deployed on that instance.
 # This is done to understand what is the deployed cluster config in each node, for example, during a CFN Stack update.
 
-
 DDB_CONFIG_STATUS = {
   DEPLOYED: "DEPLOYED",
-  SKIPPED_LIVE_UPDATE: "SKIPPED_LIVE_UPDATE"
-}
+  SKIPPED_LIVE_UPDATE: "SKIPPED_LIVE_UPDATE",
+}.freeze
 
 def save_instance_config_version_to_dynamodb(status)
   unless on_docker? || kitchen_test? && !node['interact_with_ddb']

cookbooks/aws-parallelcluster-slurm/libraries/update.rb

@@ -114,16 +114,16 @@ def is_live_update_required?
   Chef::Log.info("Changeset found: evaluating changes #{changes}")
 
   outcome = case node["cluster"]["node_type"]
-  when 'HeadNode'
-    # The head node supports live updates regardless the content of the changeset.
-    true
-  when 'ComputeFleet','LoginNode'
-    # The compute and login nodes support live updates only in specific cases:
-    #   * changeset  contains only shared storage changes that support live updates
-    storage_change_supports_live_update?(changes)
-  else
-    raise "node_type must be HeadNode, LoginNode or ComputeFleet"
-  end
+            when 'HeadNode'
+              # The head node supports live updates regardless the content of the changeset.
+              true
+            when 'ComputeFleet', 'LoginNode'
+              # The compute and login nodes support live updates only in specific cases:
+              #   * changeset  contains only shared storage changes that support live updates
+              storage_change_supports_live_update?(changes)
+            else
+              raise "node_type must be HeadNode, LoginNode or ComputeFleet"
+            end
 
   Chef::Log.info("Live update required: #{outcome}")
 end

cookbooks/aws-parallelcluster-slurm/recipes/update/update_compute.rb

@@ -15,7 +15,7 @@
 # OR CONDITIONS OF ANY KIND, express or implied. See the License for the specific language governing permissions and
 # limitations under the License.
 
-unless lambda { is_live_update_required? }.call
+unless -> { is_live_update_required? }.call
   save_instance_config_version_to_dynamodb(DDB_CONFIG_STATUS[:SKIPPED_LIVE_UPDATE])
   return
 end

cookbooks/aws-parallelcluster-slurm/recipes/update/update_login_node.rb

@@ -15,7 +15,7 @@
 # OR CONDITIONS OF ANY KIND, express or implied. See the License for the specific language governing permissions and
 # limitations under the License.
 
-unless lambda { is_live_update_required? }.call
+unless -> { is_live_update_required? }.call
   save_instance_config_version_to_dynamodb(DDB_CONFIG_STATUS[:SKIPPED_LIVE_UPDATE])
   return
 end