Fix the kitchen test condition for ptrace_scope to switch on node type and add an efa kitchen test suite for the head node

Author: dreambeyondorange

kitchen.resources-config.yml

@@ -26,15 +26,32 @@ suites:
       resource: sticky_bits
   - name: efa_configure_compute
     run_list:
+      - recipe[aws-parallelcluster::add_dependencies]
       - recipe[aws-parallelcluster-common::test_resource]
     verifier:
       controls:
         - efa_debian_system_settings_configured
     attributes:
       resource: efa:configure
       cluster:
-        enable_efa: compute
+        enable_efa: efa
         node_type: ComputeFleet
+      dependencies:
+        - recipe:aws-parallelcluster-common::node_attributes
+  - name: efa_configure_headnode
+    run_list:
+      - recipe[aws-parallelcluster::add_dependencies]
+      - recipe[aws-parallelcluster-common::test_resource]
+    verifier:
+      controls:
+        - efa_debian_system_settings_configured
+    attributes:
+      resource: efa:configure
+      cluster:
+        enable_efa: efa
+        node_type: HeadNode
+      dependencies:
+        - recipe:aws-parallelcluster-common::node_attributes
   - name: efs_configure
     run_list:
       - recipe[aws-parallelcluster::add_dependencies]
@@ -131,4 +148,4 @@ suites:
         nvidia:
           enabled: true
     driver:
-      instance_type: g4dn.2xlarge
+      instance_type: g4dn.2xlarge

test/resources/controls/aws_parallelcluster_config/efa_spec.rb

@@ -3,7 +3,21 @@
 
   only_if { os.debian? && !os_properties.virtualized? }
 
+  ptrace_scope = instance.head_node? ? 1 : 0
+  if ptrace_scope == 1
+    describe 'Verify ptrace config file is not present' do
+      subject { file('/etc/sysctl.d/99-chef-kernel.yama.ptrace_scope.conf') }
+      it { should_not exist }
+    end
+  else
+    describe 'Verify ptrace config file is present' do
+      subject { file('/etc/sysctl.d/99-chef-kernel.yama.ptrace_scope.conf') }
+      it { should exist }
+      its('content') { should match /kernel.yama.ptrace_scope = #{ptrace_scope}/ }
+    end
+  end
+
   describe kernel_parameter('kernel.yama.ptrace_scope') do
-    its('value') { should eq 0 }
+    its('value') { should eq ptrace_scope }
   end
 end