[Kitchen test] Simplify cstate check #2867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`grubby` command on Rocky 9.5 no longer writes to `/etc/default/grub`. It uses another file. To avoid too many branches based on operating system, this commit use `cpupower` command to check CPU cstate. `cpupower` doesn't work on Ubuntu20, for which this commit keeps the old checks. Signed-off-by: Hanwen <[email protected]>
hgreebe
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grubbycommand on Rocky 9.5 no longer writes to/etc/default/grub. It uses another file. To avoid too many branches based on operating system, this commit usecpupowercommand to check CPU cstate.cpupowerdoesn't work on Ubuntu20, for which this commit keeps the old checks.Tests
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.