Skip to content

[IMDS Lockdown] Add example of usage to imds-access.sh helper. #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2025
Merged

[IMDS Lockdown] Add example of usage to imds-access.sh helper. #2868

merged 3 commits into from
Feb 18, 2025

Conversation

@gmarciani
Copy link
Contributor

@gmarciani gmarciani commented Jan 30, 2025

Description of changes

Add example of usage to imds-access.sh helper.

Tests

  • Verified that the helper is printed correctly
  • Verified that imds access script works correctly (allow,deny,flush)

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani requested review from a team as code owners January 30, 2025 20:17
@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.63%. Comparing base (a21a33e) to head (f1c60e1).
Report is 7 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2868   +/-   ##
========================================
  Coverage    76.63%   76.63%           
========================================
  Files           22       22           
  Lines         2243     2243           
========================================
  Hits          1719     1719           
  Misses         524      524
Flag Coverage Δ
unittests 76.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmarciani gmarciani enabled auto-merge (rebase) February 18, 2025 02:58
@gmarciani gmarciani merged commit 1cd7740 into aws:develop Feb 18, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@himani2411 himani2411 himani2411 approved these changes

Assignees

No one assigned

Labels

3.x skip-changelog-update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmarciani @himani2411