Skip to content

Commit 1c64bfe

Browse files
committed
[CodeStyle] Ignore PyLint error 'too-many-positional-arguments'.
It's not a good practice to have many positional arguments, however we do not see a value in refactoring a module that is barely used. Signed-off-by: Giacomo Marciani <[email protected]>
1 parent 4b8bcd7 commit 1c64bfe

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

awsbatch-cli/src/awsbatch/awsbhosts.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def __init__(
6666
mem_registered,
6767
cpu_avail,
6868
mem_avail,
69-
):
69+
): # pylint: disable=too-many-positional-arguments
7070
"""Initialize the object."""
7171
self.container_instance_arn = container_instance_arn
7272
self.status = status

awsbatch-cli/src/awsbatch/awsbout.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,9 @@ def __init__(self, log, boto3_factory):
8181
self.log = log
8282
self.boto3_factory = boto3_factory
8383

84-
def run(self, job_id, head=None, tail=None, stream=None, stream_period=None):
84+
def run(
85+
self, job_id, head=None, tail=None, stream=None, stream_period=None
86+
): # pylint: disable=too-many-positional-arguments
8587
"""Print job output."""
8688
log_stream = self.__get_log_stream(job_id)
8789
if log_stream:
@@ -124,7 +126,9 @@ def __get_log_stream(self, job_id):
124126
fail("Error listing jobs from AWS Batch. Failed with exception: %s" % e)
125127
return log_stream
126128

127-
def __print_log_stream(self, log_stream, head=None, tail=None, stream=None, stream_period=None): # noqa: C901 FIXME
129+
def __print_log_stream( # noqa: C901 FIXME
130+
self, log_stream, head=None, tail=None, stream=None, stream_period=None
131+
): # pylint:disable=too-many-positional-arguments
128132
"""
129133
Ask for log stream and print it.
130134

awsbatch-cli/src/awsbatch/awsbqueues.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def _get_parser():
5050
class Queue:
5151
"""Generic queue object."""
5252

53-
def __init__(self, arn, name, priority, status, status_reason):
53+
def __init__(self, arn, name, priority, status, status_reason): # pylint: disable=too-many-positional-arguments
5454
"""Initialize the object."""
5555
self.arn = arn
5656
self.name = name

awsbatch-cli/src/awsbatch/awsbstat.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def __init__(
9494
log_stream,
9595
log_stream_url,
9696
s3_folder_url,
97-
):
97+
): # pylint: disable=too-many-positional-arguments
9898
"""Initialize the object."""
9999
self.id = job_id
100100
self.name = name
@@ -282,7 +282,9 @@ def __init__(self, log, boto3_factory):
282282
self.boto3_factory = boto3_factory
283283
self.batch_client = boto3_factory.get_client("batch")
284284

285-
def run(self, job_status, expand_children, job_queue=None, job_ids=None, show_details=False):
285+
def run(
286+
self, job_status, expand_children, job_queue=None, job_ids=None, show_details=False
287+
): # pylint: disable=too-many-positional-arguments
286288
"""Print list of jobs, by filtering by queue or by ids."""
287289
if job_ids:
288290
self.__populate_output_by_job_ids(job_ids, show_details or len(job_ids) == 1, include_parents=True)

awsbatch-cli/src/awsbatch/awsbsub.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ def run( # noqa: C901 FIXME
444444
timeout=None,
445445
dependencies=None,
446446
env=None,
447-
):
447+
): # pylint: disable=too-many-positional-arguments
448448
"""Submit the job."""
449449
try:
450450
# array properties

0 commit comments

Comments
 (0)