Add missing condition for MasterPublicIp Output

The Master Public IP from the MasterServer resource
is only available if MasterPublicIp condition is verified.

We lost this condition when created two substacks
for the master and the computes.

Signed-off-by: Enrico Usai <[email protected]>

Author: Enrico Usai

cloudformation/aws-parallelcluster.cfn.json

@@ -2790,7 +2790,7 @@
           "MasterENI": {
             "Ref": "MasterENI"
           },
-          "MasterPublicIp": {
+          "UseMasterPublicIp": {
             "Fn::If": [
               "MasterPublicIp",
               true,

cloudformation/master-server-substack.cfn.yaml

@@ -24,7 +24,7 @@ Parameters:
     Type: String
   MasterENI:
     Type: String
-  MasterPublicIp:
+  UseMasterPublicIp:
     Type: String
   ImageId:
     Type: AWS::EC2::Image::Id
@@ -221,8 +221,8 @@ Conditions:
     - !Equals
       - !Ref 'UpdateWaiterFunctionArn'
       - NONE
-  MasterPublicIp: !Equals
-    - !Ref 'MasterPublicIp'
+  HasMasterPublicIp: !Equals
+    - !Ref 'UseMasterPublicIp'
     - 'true'
 Resources:
   MasterServer:
@@ -627,7 +627,7 @@ Outputs:
   MasterPublicIP:
     Description: Public IP Address of the Master host
     Value: !GetAtt 'MasterServer.PublicIp'
-    Condition: MasterPublicIp
+    Condition: HasMasterPublicIp
   MasterPrivateDnsName:
     Description: Private DNS name of the Master host
     Value: !GetAtt 'MasterServer.PrivateDnsName'