Add validator to prevent using data_compression_type with fsx_backup_id

* DataCompressionType is not supported when creating filesystem from backup. The designed behavior is to use the existing compression setting from the backup. Add validator for this case
* DataCompressionType option cannot be specified in CFN when creating from backup, added logic to use `AWS:NoValue` if using backup

Signed-off-by: Rex <[email protected]>

Author: Rex

cli/src/pcluster/config/validators.py

@@ -232,6 +232,8 @@ def fsx_validator(section_key, section_label, pcluster_config):
     fsx_copy_tags_to_backups = fsx_section.get_param_value("copy_tags_to_backups")
     fsx_storage_type = fsx_section.get_param_value("storage_type")
     fsx_drive_cache_type = fsx_section.get_param_value("drive_cache_type")
+    fsx_backup_id = fsx_section.get_param_value("fsx_backup_id")
+    fsx_data_compression_type = fsx_section.get_param_value("data_compression_type")
 
     validate_s3_options(errors, fsx_import_path, fsx_imported_file_chunk_size, fsx_export_path, fsx_auto_import_policy)
     validate_persistent_options(errors, fsx_deployment_type, fsx_kms_key_id, fsx_per_unit_storage_throughput)
@@ -249,10 +251,22 @@ def fsx_validator(section_key, section_label, pcluster_config):
     validate_storage_type_options(
         errors, fsx_storage_type, fsx_deployment_type, fsx_per_unit_storage_throughput, fsx_drive_cache_type
     )
+    _validate_fsx_compression_type_option(errors, fsx_backup_id, fsx_data_compression_type)
 
     return errors, warnings
 
 
+def _validate_fsx_compression_type_option(errors, fsx_backup_id, fsx_data_compression_type):
+    # DataCompressionType is not supported when creating filesystem from backup.
+    # The designed behavior is to use the existing compression setting from the backup.
+    if fsx_backup_id and fsx_data_compression_type and fsx_data_compression_type != "NONE":
+        errors.append(
+            f"FSx data compression option ({fsx_data_compression_type}) cannot be specified "
+            f"when creating a filesystem from backup ({fsx_backup_id}). "
+            "To fix, please unspecify 'fsx_backup_id' or 'data_compression_type'."
+        )
+
+
 def fsx_architecture_os_validator(section_key, section_label, pcluster_config):
     errors = []
     warnings = []

cli/tests/pcluster/config/test_validators.py

@@ -1121,6 +1121,33 @@ def _kms_key_stubber(mocker, boto3_stubber, kms_key_id, expected_message, num_ca
             "'drive_cache_type' features can be used only with HDD filesystems",
             0,
         ),
+        (
+            {
+                "data_compression_type": "LZ4",
+                "fsx_backup_id": "backup-12345678",
+            },
+            None,
+            "FSx data compression option (LZ4) cannot be specified when creating a filesystem from backup",
+            0,
+        ),
+        (
+            {
+                "data_compression_type": "NONE",
+                "fsx_backup_id": "backup-12345678",
+            },
+            None,
+            "The configuration parameter 'data_compression_type' has an invalid value 'NONE'",
+            0,
+        ),
+        (
+            {
+                "data_compression_type": "LZ4",
+                "storage_capacity": 1200,
+            },
+            None,
+            None,
+            0,
+        ),
     ],
 )
 def test_fsx_validator(mocker, boto3_stubber, section_dict, bucket, expected_error, num_calls):

cloudformation/fsx-substack.cfn.json

@@ -605,10 +605,18 @@
             ]
           },
           "DataCompressionType": {
-            "Fn::Select": [
-              "19",
+            "Fn::If": [
+              "UseBackupId",
               {
-                "Ref": "FSXOptions"
+                "Ref": "AWS::NoValue"
+              },
+              {
+                "Fn::Select": [
+                  "19",
+                  {
+                    "Ref": "FSXOptions"
+                  }
+                ]
               }
             ]
           }