Skip to content

Commit a95e9e5

Browse files
[integ-test-framework] Remove check on the number of os, scheduler, instances, regions when existing cluster is specified
When test_config YAML is specified, the meaning of the standalone arguments (--oss, --schedulers, --regions, --instances) are to filter the test, rather than running the test https://github.com/aws/aws-parallelcluster/blob/develop/tests/integration-tests/test_runner.py#L814. For example, we use ``--regions` in daily run to distinguish tests in develop.yaml across China, commercial, GovCloud The check is wrong when using test_config YAML. Because we have been running test with test_config YAML, instead of fixing the check, this commit removes the check
1 parent 6990415 commit a95e9e5

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

tests/integration-tests/test_runner.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -845,15 +845,6 @@ def _get_config_arguments(args):
845845

846846

847847
def _check_args(args):
848-
# If --cluster is set only one os, scheduler, instance type and region can be provided
849-
if args.cluster:
850-
if len(args.oss) > 1 or len(args.schedulers) > 1 or len(args.instances) > 1 or len(args.regions) > 1:
851-
logger.error(
852-
"when cluster option is specified, you can have a single value for oss, regions, instances "
853-
"and schedulers and you need to make sure they match the cluster specific ones"
854-
)
855-
exit(1)
856-
857848
if not args.tests_config:
858849
assert_that(args.regions).described_as("--regions cannot be empty").is_not_empty()
859850
assert_that(args.instances).described_as("--instances cannot be empty").is_not_empty()

0 commit comments

Comments
 (0)