Print changes in the vpc_security_group_id when the update is allowed

Without this patch the update command wasn't displaying any change in the config
when the update of the vpc_security_group_id parameter was allowed (not managed fsx).

Invert test logic to verify all the expected changes are in the output and not viceversa.
This logic was hiding the fact we were not printing the change in case of allowed update
and was hiding a typo in the check result.

Signed-off-by: Enrico Usai <[email protected]>

Author: Enrico Usai

cli/src/pcluster/config/update_policy.py

@@ -285,8 +285,7 @@ def _check_unmanaged_fsx(_, patch):
         else "Remove the parameter '{0}'".format(change.param_key)
     ),
     condition_checker=_check_unmanaged_fsx,
-    # We don't want to show the change if allowed (e.g local value is empty)
-    print_succeeded=False,
+    print_succeeded=True,
 )
 
 # Update effects are unknown.

cli/tests/pcluster/config/test_config_patch.py

@@ -482,7 +482,7 @@ def test_vpc_security_id_changes(
             Change("vpc", "default", "vpc_security_group_id", src_value, dst_value, UpdatePolicy.MANAGED_FSX),
         )
         if expected_patch_allowed:
-            check = "SUCCEDED"
+            check = "SUCCEEDED"
             reason = "-"
             action_needed = None
         else:
@@ -509,7 +509,7 @@ def test_vpc_security_id_changes(
     is_patch_allowed, rows = ConfigPatch(base_config=src_conf, target_config=dst_conf).check()
     assert_that(expected_patch_allowed).is_equal_to(is_patch_allowed)
 
-    for line in rows:
+    for line in expected_message_rows:
         # Handle unicode string
         line = ["{0}".format(element) if isinstance(element, str) else element for element in line]
-        assert_that(expected_message_rows).contains(line)
+        assert_that(rows).contains(line)