Print warning when using OSes reaching EOL in 2020

Signed-off-by: Tim Lane <[email protected]>

Author: Tim Lane

cli/pcluster/config/mappings.py

@@ -32,6 +32,7 @@
     SpotPriceParam,
 )
 from pcluster.config.validators import (
+    base_os_validator,
     cluster_validator,
     compute_instance_type_validator,
     dcv_enabled_validator,
@@ -457,6 +458,7 @@
             ("base_os", {
                 "cfn_param_mapping": "BaseOS",
                 "allowed_values": ["alinux", "alinux2", "ubuntu1604", "ubuntu1804", "centos6", "centos7"],
+                "validators": [base_os_validator],
                 "required": True,
             }),
             ("scheduler", {

cli/pcluster/config/validators.py

@@ -846,3 +846,16 @@ def intel_hpc_validator(param_key, param_value, pcluster_config):
         )
 
     return errors, warnings
+
+
+def base_os_validator(param_key, param_value, pcluster_config):
+    warnings = []
+
+    eol_2020 = ["centos6", "alinux"]
+    if param_value in eol_2020:
+        warnings.append(
+            "The operating system you are using ({0}) will reach end-of-life in late 2020. It will be deprecated in "
+            "future releases of ParallelCluster".format(param_value)
+        )
+
+    return [], warnings

cli/tests/pcluster/config/test_validators.py

@@ -1195,3 +1195,19 @@ def test_fsx_os_support(mocker, base_os, expected_message):
     }
 
     utils.assert_param_validator(mocker, config_parser_dict, re.escape(expected_message) if expected_message else None)
+
+
+@pytest.mark.parametrize(
+    "base_os, expected_warning",
+    [
+        ("alinux2", None),
+        ("centos7", None),
+        ("ubuntu1604", None),
+        ("ubuntu1804", None),
+        ("centos6", "centos6.*will reach end-of-life in late 2020"),
+        ("alinux", "alinux.*will reach end-of-life in late 2020"),
+    ],
+)
+def test_base_os_validator(mocker, capsys, base_os, expected_warning):
+    config_parser_dict = {"cluster default": {"base_os": base_os}}
+    utils.assert_param_validator(mocker, config_parser_dict, capsys=capsys, expected_warning=expected_warning)