Skip to content

Commit f61e37a

Browse files
Enable DCV for us-iso regions
Signed-off-by: Hanwen <[email protected]>
1 parent 99575d9 commit f61e37a

File tree

4 files changed

+0
-14
lines changed

4 files changed

+0
-14
lines changed

cli/src/pcluster/config/cluster_config.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1635,7 +1635,6 @@ def _register_validators(self, context: ValidatorContext = None): # noqa: D102
16351635
imds_support=self.imds.imds_support,
16361636
)
16371637
if self.head_node.dcv:
1638-
self._register_validator(FeatureRegionValidator, feature=Feature.DCV, region=self.region)
16391638
self._register_validator(
16401639
DcvValidator,
16411640
instance_type=self.head_node.instance_type,
@@ -2969,7 +2968,6 @@ def login_nodes_subnet_ids(self):
29692968

29702969
def _register_login_node_validators(self):
29712970
"""Register all login node validators to ensure that the resource parameters are valid."""
2972-
has_dcv_configured = False
29732971
# Check if all subnets(head node, Login nodes, compute nodes) are in the same VPC and support DNS.
29742972
self._register_validator(
29752973
SubnetsValidator,
@@ -3002,10 +3000,6 @@ def _register_login_node_validators(self):
30023000
os=self.image.os,
30033001
architecture=pool.architecture,
30043002
)
3005-
has_dcv_configured = True
3006-
3007-
if has_dcv_configured:
3008-
self._register_validator(FeatureRegionValidator, feature=Feature.DCV, region=self.region)
30093003

30103004
def _register_validators(self, context: ValidatorContext = None): # noqa: C901
30113005
super()._register_validators(context)

cli/src/pcluster/constants.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ class Feature(Enum):
244244

245245
UNSUPPORTED_FEATURES_MAP = {
246246
Feature.BATCH: ["ap-northeast-3", "us-iso"],
247-
Feature.DCV: ["us-iso"],
248247
Feature.FSX_LUSTRE: ["us-isob"],
249248
Feature.FILE_CACHE: ["us-iso"],
250249
Feature.FSX_ONTAP: ["us-iso"],

cli/tests/pcluster/test_utils.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -579,10 +579,6 @@ async def async_method(self, param):
579579
(Feature.BATCH, "us-iso-west-1", False),
580580
(Feature.BATCH, "us-isob-east-1", False),
581581
(Feature.BATCH, "us-isoWHATEVER", False),
582-
(Feature.DCV, "us-iso-east-1", False),
583-
(Feature.DCV, "us-iso-west-1", False),
584-
(Feature.DCV, "us-isob-east-1", False),
585-
(Feature.DCV, "us-isoWHATEVER", False),
586582
(Feature.FSX_LUSTRE, "us-isob-east-1", False),
587583
(Feature.FSX_LUSTRE, "us-isobWHATEVER", False),
588584
(Feature.FSX_ONTAP, "us-iso-east-1", False),
@@ -596,7 +592,6 @@ async def async_method(self, param):
596592
(Feature.SLURM_DATABASE, "us-isoWHATEVER", True),
597593
(Feature.CLUSTER_HEALTH_METRICS, "us-isoWHATEVER", False),
598594
(Feature.BATCH, "WHATEVER-ELSE", True),
599-
(Feature.DCV, "WHATEVER-ELSE", True),
600595
(Feature.FSX_LUSTRE, "WHATEVER-ELSE", True),
601596
(Feature.FSX_ONTAP, "WHATEVER-ELSE", True),
602597
(Feature.FSX_OPENZFS, "WHATEVER-ELSE", True),

cli/tests/pcluster/validators/test_feature_validators.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
[
2424
(Feature.BATCH, True, None),
2525
(Feature.BATCH, False, "AWS Batch scheduler is not supported in region 'WHATEVER-REGION'"),
26-
(Feature.DCV, True, None),
27-
(Feature.DCV, False, "Amazon DCV is not supported in region 'WHATEVER-REGION'"),
2826
(Feature.FSX_LUSTRE, True, None),
2927
(Feature.FSX_LUSTRE, False, "FSx Lustre is not supported in region 'WHATEVER-REGION'"),
3028
(Feature.FSX_ONTAP, True, None),

0 commit comments

Comments
 (0)