Sanity check only on calls that mutate stack; output CREATE_FAILED errors with status call

Author: Dougal Ballantyne

cli/cfncluster/cfncluster.py

@@ -260,7 +260,8 @@ def status(args):
         sys.stdout.write('\rStatus: %s' % status)
         sys.stdout.flush()
         if not args.nowait:
-            while ((status != 'CREATE_COMPLETE') and (status != 'UPDATE_COMPLETE') and (status != 'ROLLBACK_COMPLETE')):
+            while ((status != 'CREATE_COMPLETE') and (status != 'UPDATE_COMPLETE')
+                   and (status != 'ROLLBACK_COMPLETE') and (status != 'CREATE_FAILED')):
                 time.sleep(5)
                 status = cfnconn.describe_stacks(stack)[0].stack_status
                 events = cfnconn.describe_stack_events(stack)[0]
@@ -273,6 +274,11 @@ def status(args):
                 outputs = cfnconn.describe_stacks(stack)[0].outputs
                 for output in outputs:
                     print output
+            elif ((status == 'ROLLBACK_COMPLETE') or (status == 'CREATE_FAILED')):
+                events = cfnconn.describe_stack_events(stack)
+                for event in events:
+                    if event.resource_status == 'CREATE_FAILED':
+                        print event.timestamp, event.resource_status, event.resource_type, event.logical_resource_id, event.resource_status_reason
         else:
             sys.stdout.write('\n')
             sys.stdout.flush()
@@ -290,7 +296,7 @@ def status(args):
 
 
 def delete(args):
-    print('Terminating: %s' % args.cluster_name)
+    print('Deleting: %s' % args.cluster_name)
     stack = ('cfncluster-' + args.cluster_name)
 
     config = cfnconfig.CfnClusterConfig(args)

cli/cfncluster/cfnconfig.py

@@ -79,6 +79,12 @@ def __init__(self, args):
             self.__sanity_check = __config.getboolean('global', 'sanity_check')
         except ConfigParser.NoOptionError:
             self.__sanity_check = False
+        # Only check config on calls that mutate it
+        __args_func = self.args.func.func_name
+        if (__args_func == 'create' or __args_func == 'update') and self.__sanity_check is True:
+            pass
+        else:
+            self.__sanity_check = False
 
         # Determine the EC2 region to used used or default to us-east-1
         # Order is 1) CLI arg 2) AWS_DEFAULT_REGION env 3) Config file 4) us-east-1