fix minor stuff

Author: kai-ion

src/aws-cpp-sdk-core/include/aws/core/client/UserAgent.h

@@ -32,7 +32,6 @@ enum class UserAgentFeature {
   ACCOUNT_ID_MODE_REQUIRED,
   RESOLVED_ACCOUNT_ID,
   GZIP_REQUEST_COMPRESSION,
-  CREDENTIALS_CODE,
   CREDENTIALS_ENV_VARS,
   CREDENTIALS_PROFILE,
   CREDENTIALS_PROFILE_PROCESS,

src/aws-cpp-sdk-core/source/auth/AWSCredentialsProviderChain.cpp

@@ -25,7 +25,6 @@ AWSCredentials AWSCredentialsProviderChain::GetAWSCredentials()
       AWSCredentials credentials = m_cachedProvider->GetAWSCredentials();
       if (!credentials.GetAWSAccessKeyId().empty() && !credentials.GetAWSSecretKey().empty())
       {
-        credentials.AddUserAgentFeature(Aws::Client::UserAgentFeature::CREDENTIALS_CODE);
         return credentials;
       }
     }
@@ -36,7 +35,6 @@ AWSCredentials AWSCredentialsProviderChain::GetAWSCredentials()
         if (!credentials.GetAWSAccessKeyId().empty() && !credentials.GetAWSSecretKey().empty())
         {
             m_cachedProvider = credentialsProvider;
-            credentials.AddUserAgentFeature(Aws::Client::UserAgentFeature::CREDENTIALS_CODE);
             return credentials;
         }
     }

src/aws-cpp-sdk-core/source/client/UserAgent.cpp

@@ -42,7 +42,6 @@ const std::pair<UserAgentFeature, const char*> BUSINESS_METRIC_MAPPING[] = {
     {UserAgentFeature::ACCOUNT_ID_MODE_REQUIRED, "R"},
     {UserAgentFeature::RESOLVED_ACCOUNT_ID, "T"},
     {UserAgentFeature::GZIP_REQUEST_COMPRESSION, "L"},
-    {UserAgentFeature::CREDENTIALS_CODE, "e"},
     {UserAgentFeature::CREDENTIALS_ENV_VARS, "g"},
     {UserAgentFeature::CREDENTIALS_PROFILE, "n"},
     {UserAgentFeature::CREDENTIALS_PROFILE_PROCESS, "v"},

tests/aws-cpp-sdk-core-tests/aws/auth/CredentialTrackingTest.cpp

@@ -152,20 +152,6 @@ class CredentialTrackingTest : public Aws::Testing::AwsCppSdkGTestSuite
     }
 };
 
-TEST_F(CredentialTrackingTest, TestCredentialsCodeTracking)
-{
-    // Set up environment credentials for the provider chain
-    Aws::Environment::EnvironmentRAII testEnvironment{{
-        {"AWS_ACCESS_KEY_ID", "test-access-key"},
-        {"AWS_SECRET_ACCESS_KEY", "test-secret-key"},
-  }};
-
-    // Use DefaultAWSCredentialsProviderChain which will add CREDENTIALS_CODE
-    auto credsProvider = Aws::MakeShared<Aws::Auth::DefaultAWSCredentialsProviderChain>(TEST_LOG_TAG);
-    RunTestWithCredentialsProvider(std::move(credsProvider), "e");
-}
-
-
 TEST_F(CredentialTrackingTest, TestEnvironmentCredentialsTracking)
 {
     Aws::Environment::EnvironmentRAII testEnvironment{{

tests/aws-cpp-sdk-core-tests/aws/auth/SSOCredentialTrackingTest.cpp

@@ -41,9 +41,9 @@ class CredentialTestingClient : public AWSClient
 {
 public:
   CredentialTestingClient() : AWSClient(ClientConfiguration(), Aws::MakeShared<AWSAuthV4Signer>(TEST_LOG_TAG, Aws::MakeShared<DefaultAWSCredentialsProviderChain>(TEST_LOG_TAG),
-      "rds", Aws::Region::US_EAST_1), Aws::MakeShared<XmlErrorMarshaller>(TEST_LOG_TAG)) {}
+      "service", Aws::Region::US_EAST_1), Aws::MakeShared<MockAWSErrorMarshaller>(TEST_LOG_TAG)) {}
   CredentialTestingClient(const Aws::Client::ClientConfiguration& configuration, const std::shared_ptr<Aws::Client::AWSAuthSigner>& signer) :
-      AWSClient(configuration, signer, Aws::MakeShared<XmlErrorMarshaller>(TEST_LOG_TAG)) {}
+      AWSClient(configuration, signer, Aws::MakeShared<MockAWSErrorMarshaller>(TEST_LOG_TAG)) {}
 
   Aws::Client::HttpResponseOutcome PublicAttemptExhaustively(
         const Aws::Http::URI& uri,