Skip to content

Commit 03f7837

Browse files
committed
updated test to use .find before creatng the profile
1 parent bac51d2 commit 03f7837

File tree

1 file changed

+30
-12
lines changed

1 file changed

+30
-12
lines changed

tests/aws-cpp-sdk-core-tests/aws/config/ServiceEndpointsConfigFileLoaderTest.cpp

Lines changed: 30 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestServiceSpecificEndpoints)
3939
ASSERT_NE(profiles.end(), profiles.find("default"));
4040

4141
// Test global endpoint
42-
const auto& profile = profiles["default"];
42+
auto profileIt = profiles.find("default");
43+
ASSERT_NE(profiles.end(), profileIt);
44+
const auto& profile = profileIt->second;
4345
auto globalEndpoint = profile.GetEndpointUrl();
4446
ASSERT_TRUE(globalEndpoint.has_value());
4547
ASSERT_STREQ("https://global.example.com", globalEndpoint->c_str());
@@ -66,7 +68,9 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestServiceSpecificEndpointsOnly)
6668
AWSConfigFileProfileConfigLoader loader(configFile.GetFileName(), true);
6769
ASSERT_TRUE(loader.Load());
6870
auto profiles = loader.GetProfiles();
69-
const auto& profile = profiles["dev-minio"];
71+
auto profileIt = profiles.find("dev-minio");
72+
ASSERT_NE(profiles.end(), profileIt);
73+
const auto& profile = profileIt->second;
7074

7175
// Test that global endpoint is null when not set
7276
auto globalEndpoint = profile.GetEndpointUrl();
@@ -90,7 +94,9 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestGlobalEndpointOnly)
9094
AWSConfigFileProfileConfigLoader loader(configFile.GetFileName(), true);
9195
ASSERT_TRUE(loader.Load());
9296
auto profiles = loader.GetProfiles();
93-
const auto& profile = profiles["dev-global"];
97+
auto profileIt = profiles.find("dev-global");
98+
ASSERT_NE(profiles.end(), profileIt);
99+
const auto& profile = profileIt->second;
94100

95101
// Test global endpoint
96102
auto globalEndpoint = profile.GetEndpointUrl();
@@ -118,7 +124,9 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestServiceSpecificAndGlobalEndpoin
118124
AWSConfigFileProfileConfigLoader loader(configFile.GetFileName(), true);
119125
ASSERT_TRUE(loader.Load());
120126
auto profiles = loader.GetProfiles();
121-
const auto& profile = profiles["dev-s3-specific-and-global"];
127+
auto profileIt = profiles.find("dev-s3-specific-and-global");
128+
ASSERT_NE(profiles.end(), profileIt);
129+
const auto& profile = profileIt->second;
122130

123131
// Test services name is parsed correctly
124132
auto servicesName = profile.GetServicesName();
@@ -148,7 +156,9 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestMultipleServicesInDefinition)
148156
AWSConfigFileProfileConfigLoader loader(configFile.GetFileName(), true);
149157
ASSERT_TRUE(loader.Load());
150158
auto profiles = loader.GetProfiles();
151-
const auto& profile = profiles["dev"];
159+
auto profileIt = profiles.find("dev");
160+
ASSERT_NE(profiles.end(), profileIt);
161+
const auto& profile = profileIt->second;
152162

153163
// Test services name is parsed correctly
154164
auto servicesName = profile.GetServicesName();
@@ -170,7 +180,9 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestIgnoreGlobalEndpointInServicesS
170180
AWSConfigFileProfileConfigLoader loader(configFile.GetFileName(), true);
171181
ASSERT_TRUE(loader.Load());
172182
auto profiles = loader.GetProfiles();
173-
const auto& profile = profiles["testing"];
183+
auto profileIt = profiles.find("testing");
184+
ASSERT_NE(profiles.end(), profileIt);
185+
const auto& profile = profileIt->second;
174186

175187
// Test that global endpoint in services section is ignored
176188
auto globalEndpoint = profile.GetEndpointUrl();
@@ -202,8 +214,12 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestSourceProfileEndpointIsolation)
202214
AWSConfigFileProfileConfigLoader loader(configFile.GetFileName(), true);
203215
ASSERT_TRUE(loader.Load());
204216
auto profiles = loader.GetProfiles();
205-
const auto& profileB = profiles["B"];
206-
const auto& profileA = profiles["A"];
217+
auto profileBIt = profiles.find("B");
218+
ASSERT_NE(profiles.end(), profileBIt);
219+
const auto& profileB = profileBIt->second;
220+
auto profileAIt = profiles.find("A");
221+
ASSERT_NE(profiles.end(), profileAIt);
222+
const auto& profileA = profileAIt->second;
207223

208224
// Test that profile B has services name
209225
auto servicesBName = profileB.GetServicesName();
@@ -242,9 +258,9 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestIgnoreConfiguredEndpointUrls)
242258
auto profiles = loader.GetProfiles();
243259

244260
// Test flag is parsed and stored
245-
ASSERT_STREQ("true", profiles["default"].GetValue("ignore_configured_endpoint_urls").c_str());
246-
ASSERT_STREQ("TRUE", profiles["test"].GetValue("ignore_configured_endpoint_urls").c_str());
247-
ASSERT_STREQ("", profiles["empty"].GetValue("ignore_configured_endpoint_urls").c_str());
261+
ASSERT_STREQ("true", profiles.find("default")->second.GetValue("ignore_configured_endpoint_urls").c_str());
262+
ASSERT_STREQ("TRUE", profiles.find("test")->second.GetValue("ignore_configured_endpoint_urls").c_str());
263+
ASSERT_STREQ("", profiles.find("empty")->second.GetValue("ignore_configured_endpoint_urls").c_str());
248264
}
249265

250266
TEST_F(ServiceEndpointsConfigFileLoaderTest, TestMultipleServicesDefinitions)
@@ -265,7 +281,9 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestMultipleServicesDefinitions)
265281
AWSConfigFileProfileConfigLoader loader(configFile.GetFileName(), true);
266282
ASSERT_TRUE(loader.Load());
267283
auto profiles = loader.GetProfiles();
268-
const auto& profile = profiles["dev"];
284+
auto profileIt = profiles.find("dev");
285+
ASSERT_NE(profiles.end(), profileIt);
286+
const auto& profile = profileIt->second;
269287

270288
// Test services name is parsed correctly
271289
auto servicesName = profile.GetServicesName();

0 commit comments

Comments
 (0)