Smoke tests environment improvements

- Update run_smoke_tests.py with proper exit codes
- Update run-al2-smoke-tests.sh script

Author: pulimsr

tools/scripts/build-tests/run-al2-smoke-tests.sh

@@ -15,9 +15,6 @@ if [ -z "$CODEBUILD_SRC_DIR" ]; then
   exit 1
 fi
 
-echo "Contents of CODEBUILD_SRC_DIR: ${CODEBUILD_SRC_DIR}"
-export AWS_SMOKE_TEST_SERVICE_IDS=$(cat $CODEBUILD_SRC_DIR/feature-service-id.json | sed 's/[^:]*:"\\([^"]*\\)"/\\1,/g' | sed 's/,}$//')
-ls -la
 export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${CODEBUILD_SRC_DIR}/al2-install/lib64/"
 cd "${CODEBUILD_SRC_DIR}/al2-build"
 python3 "../aws-sdk-cpp/tools/scripts/run_smoke_tests.py" --testDir "${CODEBUILD_SRC_DIR}/al2-build" | tee -a results.txt

tools/scripts/run_smoke_tests.py

@@ -6,14 +6,6 @@
 import json
 from collections import defaultdict
 
-def should_run_service(services):
-    service_ids = os.environ.get('AWS_SMOKE_TEST_SERVICE_IDS', '')
-    print("AWS_SMOKE_TEST_SERVICE_IDS:",service_ids)
-    if not service_ids:
-        return services
-    allowed_services = service_ids.split(',')
-    return [service for service in services if service in allowed_services]
-
 def main():
     parser = argparse.ArgumentParser(description='Run smoke tests')
     parser.add_argument('--testDir', default='./build', help='Path to build directory')
@@ -37,14 +29,19 @@ def main():
     total_tests = 0
     all_results = defaultdict(list)
 
-    services=should_run_service(services)
+    service_ids = os.environ.get('AWS_SMOKE_TEST_SERVICE_IDS', '')
+    if not service_ids:
+        return 0
+    allowed_services = service_ids.split(',')
+    allowed_services = [s.strip().lower().replace(' ', '-') for s in allowed_services]  # Convert uppercase to lowercase and spaces to hyphens
+    services=[service for service in services if service in allowed_services]
 
     for service in services:
         executable = os.path.join(smoke_tests_dir, service, f"{service}-smoke-tests")
 
         with tempfile.NamedTemporaryFile(mode='w+', suffix='.json') as temp_file:
             json_output_path = temp_file.name
-            temp_file.close()  # Close it so other processes can write to it
+            temp_file.close()
             test_command = [executable, f'--gtest_output=json:{json_output_path}']
             subprocess.run(test_command, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)