changed from dynamic casting

Author: kai-ion

src/aws-cpp-sdk-core/include/aws/core/auth/signer/AWSAuthSignerBase.h

@@ -14,6 +14,8 @@
 
 namespace Aws
 {
+    class AmazonWebServiceRequest;
+
     namespace Http
     {
         class HttpRequest;
@@ -82,6 +84,16 @@ namespace Aws
                 return SignRequest(request);
             }
 
+            /**
+             * Signs the request itself with access to the original AmazonWebServiceRequest for credential tracking.
+             * Default implementation calls the standard SignRequest method.
+             */
+            virtual bool SignRequest(Aws::Http::HttpRequest& request, Aws::AmazonWebServiceRequest& awsRequest, const char* region, const char* serviceName, bool signBody) const
+            {
+                AWS_UNREFERENCED_PARAM(awsRequest);
+                return SignRequest(request, region, serviceName, signBody);
+            }
+
             /**
              * Signs a single event message in an event stream.
              * The input message buffer is copied and signed. The message's input buffer will be deallocated and a new

src/aws-cpp-sdk-core/include/aws/core/auth/signer/AWSAuthV4Signer.h

@@ -149,7 +149,7 @@ namespace Aws
              * and https is being used then the body of the payload will not be signed.
              * This overload passes the AWS request to the credentials provider for user agent feature tracking.
              */
-            bool SignRequest(Aws::Http::HttpRequest& request, Aws::AmazonWebServiceRequest& awsRequest, const char* region, const char* serviceName, bool signBody) const;
+            bool SignRequest(Aws::Http::HttpRequest& request, Aws::AmazonWebServiceRequest& awsRequest, const char* region, const char* serviceName, bool signBody) const override;
 
             /**
             * Takes a request and signs the URI based on the HttpMethod, URI and other info from the request.

src/aws-cpp-sdk-core/source/client/AWSClient.cpp

@@ -581,11 +581,7 @@ HttpResponseOutcome AWSClient::AttemptOneRequest(const std::shared_ptr<Aws::Http
     auto signer = GetSignerByName(signerName);
     auto signedRequest = TracingUtils::MakeCallWithTiming<bool>([&]() -> bool {
             // Use request-aware signing for credential tracking
-            auto* v4Signer = dynamic_cast<AWSAuthV4Signer*>(signer);
-            if (v4Signer) {
-                return v4Signer->SignRequest(*httpRequest, const_cast<Aws::AmazonWebServiceRequest&>(request), signerRegionOverride, signerServiceNameOverride, true);
-            }
-            return signer->SignRequest(*httpRequest, signerRegionOverride, signerServiceNameOverride, true);
+            return signer->SignRequest(*httpRequest, const_cast<Aws::AmazonWebServiceRequest&>(request), signerRegionOverride, signerServiceNameOverride, true);
         },
         TracingUtils::SMITHY_CLIENT_SIGNING_METRIC,
         *m_telemetryProvider->getMeter(this->GetServiceClientName(), {}),