CredentialProviderConfiguration declaration update

Author: pulimsr

src/aws-cpp-sdk-core/include/aws/core/client/ClientConfiguration.h

@@ -88,19 +88,6 @@ namespace Aws
             bool shouldDisableIMDS = false;
         };
 
-        /**
-         * Configuration structure for credential providers in the AWS SDK.
-         * This structure allows passing configuration options to credential providers
-         * such as profile name and client configuration for HTTP requests made by
-         * credential providers that need to make network calls (e.g., InstanceProfileCredentialsProvider).
-         */
-        struct CredentialProviderConfiguration {
-          /**
-           * AWS profile name to use for credentials.
-           */
-          Aws::String profile;
-        };
-
         /**
          * This mutable structure is used to configure any of the AWS clients.
          * Default values can only be overwritten prior to passing to the client constructors.
@@ -169,11 +156,6 @@ namespace Aws
              */
             ProviderFactories configFactories = ProviderFactories::defaultFactories;
 
-            /**
-             * Credential provider configuration options.
-             */
-            CredentialProviderConfiguration credentialProviderConfig;
-
             /**
              * User Agent string user for http calls. This is filled in for you in the constructor. Don't override this unless you have a really good reason.
              */
@@ -514,5 +496,17 @@ namespace Aws
         AWS_CORE_API Aws::String ComputeUserAgentString(ClientConfiguration const * const pConfig = nullptr);
 
         AWS_CORE_API Aws::String FilterUserAgentToken(char const * const token);
+        /**
+        * Configuration structure for credential providers in the AWS SDK.
+        * This structure allows passing configuration options to credential providers
+        * such as profile name and client configuration for HTTP requests made by
+        * credential providers that need to make network calls (e.g., InstanceProfileCredentialsProvider).
+        */
+        struct CredentialProviderConfiguration {
+          /**
+          * AWS profile name to use for credentials.
+          */
+          Aws::String profile;
+        }credentialProviderConfig;
     } // namespace Client
 } // namespace Aws

src/aws-cpp-sdk-core/source/auth/AWSCredentialsProviderChain.cpp

@@ -85,7 +85,7 @@ DefaultAWSCredentialsProviderChain::DefaultAWSCredentialsProviderChain() : AWSCr
     }
 }
 
-DefaultAWSCredentialsProviderChain::DefaultAWSCredentialsProviderChain(const Aws::Client::CredentialProviderConfiguration& config) : AWSCredentialsProviderChain()
+DefaultAWSCredentialsProviderChain::DefaultAWSCredentialsProviderChain(const Aws::Client::CredentialProviderConfiguration& config)
 {
     AddProvider(Aws::MakeShared<EnvironmentAWSCredentialsProvider>(DefaultCredentialsProviderChainTag));
     AddProvider(Aws::MakeShared<ProfileConfigFileAWSCredentialsProvider>(DefaultCredentialsProviderChainTag,config.profile.c_str()));

tools/code-generation/generator/src/main/resources/com/amazonaws/util/awsclientgenerator/velocity/cpp/ServiceClientSourceInit.vm

@@ -63,7 +63,6 @@
 #set($AdditionalServiceSpecificConfigLoadString = "Load${metadata.classNamePrefix}SpecificConfig(config);")
 #end
 #set($clientConfigurationNamespace = "Client")
-#set($defaultCredentialsProviderChainParam = "Aws::MakeShared<DefaultAWSCredentialsProviderChain>(ALLOCATION_TAG)")
 #set($defaultCredentialsProviderChainParam = "Aws::MakeShared<DefaultAWSCredentialsProviderChain>(ALLOCATION_TAG, clientConfiguration.credentialProviderConfig)")
 #set($s3ExpressIdentityProviderParam = "clientConfiguration.identityProviderSupplier(*this)")
 #set($simpleCredentialsProviderParam = "Aws::MakeShared<SimpleAWSCredentialsProvider>(ALLOCATION_TAG, credentials)")