Skip to content

Commit 396d7f5

Browse files
committed
update perf test to handle unknown build mode param
1 parent c6898fe commit 396d7f5

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

tests/performance-tests/src/reporting/JsonReportingMetrics.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,13 +188,15 @@ void JsonReportingMetrics::DumpJson() const {
188188
jsonMetric.WithInt64("date", record.date.Seconds());
189189

190190
if (!record.dimensions.empty()) {
191-
Aws::Utils::Array<Aws::Utils::Json::JsonValue> dimensionsArray(record.dimensions.size() + 1);
191+
Aws::Utils::Array<Aws::Utils::Json::JsonValue> dimensionsArray(record.dimensions.size() + (m_buildMode == "unknown" ? 0 : 1));
192192
size_t dimensionIndex = 0;
193193

194-
Aws::Utils::Json::JsonValue buildModeDimension;
195-
buildModeDimension.WithString("name", "build-mode");
196-
buildModeDimension.WithString("value", m_buildMode);
197-
dimensionsArray[dimensionIndex++] = std::move(buildModeDimension);
194+
if (m_buildMode != "unknown") {
195+
Aws::Utils::Json::JsonValue buildModeDimension;
196+
buildModeDimension.WithString("name", "build-mode");
197+
buildModeDimension.WithString("value", m_buildMode);
198+
dimensionsArray[dimensionIndex++] = std::move(buildModeDimension);
199+
}
198200

199201
for (const auto& dim : record.dimensions) {
200202
Aws::Utils::Json::JsonValue dimension;

0 commit comments

Comments
 (0)