update to use a service object instead of using getvalue

Author: kai-ion

src/aws-cpp-sdk-core/include/aws/core/config/AWSProfileConfig.h

@@ -115,7 +115,7 @@ namespace Aws
                 return iter->second;
             }
 
-            inline const Services& GetServiceEndpoints() const { return m_services; }
+            inline const Services& GetServices() const { return m_services; }
 
             inline Aws::Crt::Optional<Aws::String> GetEndpointUrl() const {
                 const Aws::String& endpoint = GetValue("endpoint_url");

tests/aws-cpp-sdk-core-tests/aws/config/ServiceEndpointsConfigFileLoaderTest.cpp

@@ -47,7 +47,7 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestServiceSpecificEndpoints)
     ASSERT_STREQ("https://global.example.com", globalEndpoint->c_str());
 
     // Test services endpoints are parsed correctly
-    const auto& services = profile.GetServiceEndpoints();
+    const auto& services = profile.GetServices();
     ASSERT_TRUE(services.IsSet());
     const auto& endpoints = services.GetEndpoints();
     ASSERT_EQ(2u, endpoints.size());
@@ -79,7 +79,7 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestServiceSpecificEndpointsOnly)
     ASSERT_FALSE(globalEndpoint.has_value());
 
     // Test services endpoints are parsed correctly
-    const auto& services = profile.GetServiceEndpoints();
+    const auto& services = profile.GetServices();
     ASSERT_TRUE(services.IsSet());
     const auto& endpoints = services.GetEndpoints();
     ASSERT_EQ(1u, endpoints.size());
@@ -108,7 +108,7 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestGlobalEndpointOnly)
     ASSERT_STREQ("https://play.min.io:9000", globalEndpoint->c_str());
 
     // Test that services endpoints are not set
-    const auto& services = profile.GetServiceEndpoints();
+    const auto& services = profile.GetServices();
     ASSERT_FALSE(services.IsSet());
 }
 
@@ -133,7 +133,7 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestServiceSpecificAndGlobalEndpoin
     const auto& profile = profileIt->second;
 
     // Test services endpoints are parsed correctly
-    const auto& services = profile.GetServiceEndpoints();
+    const auto& services = profile.GetServices();
     ASSERT_TRUE(services.IsSet());
     const auto& endpoints = services.GetEndpoints();
     ASSERT_EQ(1u, endpoints.size());
@@ -167,7 +167,7 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestMultipleServicesInDefinition)
   const auto& profile = profileIt->second;
 
   // Test services endpoints are parsed correctly
-  const auto& services = profile.GetServiceEndpoints();
+  const auto& services = profile.GetServices();
   ASSERT_TRUE(services.IsSet());
   const auto& endpoints = services.GetEndpoints();
   ASSERT_EQ(2u, endpoints.size());
@@ -198,7 +198,7 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestIgnoreGlobalEndpointInServicesS
     ASSERT_FALSE(globalEndpoint.has_value());
 
     // Test that services endpoints are empty (global endpoint_url ignored)
-    const auto& services = profile.GetServiceEndpoints();
+    const auto& services = profile.GetServices();
     ASSERT_TRUE(services.IsSet());
     const auto& endpoints = services.GetEndpoints();
     ASSERT_EQ(0u, endpoints.size());
@@ -232,7 +232,7 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestSourceProfileEndpointIsolation)
     const auto& profileA = profileAIt->second;
 
     // Test that profile B has services endpoints
-    const auto& servicesB = profileB.GetServiceEndpoints();
+    const auto& servicesB = profileB.GetServices();
     ASSERT_TRUE(servicesB.IsSet());
     const auto& endpointsB = servicesB.GetEndpoints();
     ASSERT_EQ(1u, endpointsB.size());
@@ -248,7 +248,7 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestSourceProfileEndpointIsolation)
     ASSERT_STREQ("https://profile-a-endpoint.aws/", globalEndpointA->c_str());
 
     // Test that profile A has no services name
-    const auto& servicesA = profileA.GetServiceEndpoints();
+    const auto& servicesA = profileA.GetServices();
     ASSERT_FALSE(servicesA.IsSet());
 }
 
@@ -299,7 +299,7 @@ TEST_F(ServiceEndpointsConfigFileLoaderTest, TestMultipleServicesDefinitions)
     const auto& profile = profileIt->second;
 
     // Test services endpoints are parsed correctly
-    const auto& services = profile.GetServiceEndpoints();
+    const auto& services = profile.GetServices();
     ASSERT_TRUE(services.IsSet());
     const auto& endpoints = services.GetEndpoints();
     ASSERT_EQ(1u, endpoints.size());