checking 200 with error message responses

Author: pulimsr

generated/src/aws-cpp-sdk-s3-crt/source/S3CrtClient.cpp

@@ -687,9 +687,9 @@ void S3CrtClient::S3CrtRequestFinishCallback(struct aws_s3_meta_request* meta_re
 
 Aws::Client::XmlOutcome S3CrtClient::GenerateXmlOutcome(const std::shared_ptr<HttpResponse>& response) const {
   Aws::Client::HttpResponseOutcome httpOutcome;
-  if (AWSClient::DoesResponseGenerateError(response)) {
+  auto error = GetErrorMarshaller()->Marshall(*response);
+  if (error.GetErrorType() != Aws::Client::CoreErrors::UNKNOWN) {
     AWS_LOGSTREAM_DEBUG(ALLOCATION_TAG, "Request returned error. Attempting to generate appropriate error codes from response");
-    auto error = BuildAWSError(response);
     httpOutcome = HttpResponseOutcome(std::move(error));
   } else {
     httpOutcome = HttpResponseOutcome(std::move(response));

tools/code-generation/generator/src/main/resources/com/amazonaws/util/awsclientgenerator/velocity/cpp/s3/s3-crt/S3CrtSpecificOperations.vm

@@ -209,10 +209,10 @@ void S3CrtClient::S3CrtRequestFinishCallback(struct aws_s3_meta_request *meta_re
 Aws::Client::XmlOutcome S3CrtClient::GenerateXmlOutcome(const std::shared_ptr<HttpResponse>& response) const
 {
   Aws::Client::HttpResponseOutcome httpOutcome;
-  if (AWSClient::DoesResponseGenerateError(response))
+  auto error = GetErrorMarshaller()->Marshall(*response);
+  if (error.GetErrorType() != Aws::Client::CoreErrors::UNKNOWN)
   {
     AWS_LOGSTREAM_DEBUG(ALLOCATION_TAG, "Request returned error. Attempting to generate appropriate error codes from response");
-    auto error = BuildAWSError(response);
     httpOutcome = HttpResponseOutcome(std::move(error));
   }
   else

tools/code-generation/generator/src/main/resources/com/amazonaws/util/awsclientgenerator/velocity/cpp/s3/s3-crt/SmithyS3CrtSpecificOperations.vm

@@ -209,10 +209,10 @@ void S3CrtClient::S3CrtRequestFinishCallback(struct aws_s3_meta_request *meta_re
 Aws::Client::XmlOutcome S3CrtClient::GenerateXmlOutcome(const std::shared_ptr<HttpResponse>& response) const
 {
   Aws::Client::HttpResponseOutcome httpOutcome;
-  if (smithy::client::Utils::DoesResponseGenerateError(response))
+  auto error = GetErrorMarshaller()->Marshall(*response);
+  if (error.GetErrorType() != Aws::Client::CoreErrors::UNKNOWN)
   {
     AWS_LOGSTREAM_DEBUG(ALLOCATION_TAG, "Request returned error. Attempting to generate appropriate error codes from response");
-    auto error = GetErrorMarshaller()->BuildAWSError(response);
     httpOutcome = HttpResponseOutcome(std::move(error));
   }
   else