new todos

Author: kai-ion

src/aws-cpp-sdk-core/include/aws/core/auth/AWSCredentialsProvider.h

@@ -114,6 +114,7 @@ namespace Aws
              * Returns empty credentials object.
              */
             inline AWSCredentials GetAWSCredentials() override { return AWSCredentials(); }
+
         };
 
         /**

src/aws-cpp-sdk-core/source/auth/AWSCredentialsProvider.cpp

@@ -68,7 +68,7 @@ bool AWSCredentialsProvider::IsTimeToRefresh(long reloadFrequency)
 static const char* ENVIRONMENT_LOG_TAG = "EnvironmentAWSCredentialsProvider";
 
 
-AWSCredentials EnvironmentAWSCredentialsProvider::GetAWSCredentials()
+AWSCredentials EnvironmentAWSCredentialsProvider::GetAWSCredentials() //pass in request or return request for tracking
 {
     auto accessKey = Aws::Environment::GetEnv(ACCESS_KEY_ENV_VAR);
     AWSCredentials credentials;
@@ -103,6 +103,12 @@ AWSCredentials EnvironmentAWSCredentialsProvider::GetAWSCredentials()
         }
     }
 
+    if (!credentials.IsEmpty()) {
+      // TODO: this will work
+      // TODO: how does request get here?????
+      // request.AddFeature(ENV_VAR)
+    }
+
     return credentials;
 }
 

src/aws-cpp-sdk-core/source/auth/AWSCredentialsProviderChain.cpp

@@ -34,6 +34,9 @@ AWSCredentials AWSCredentialsProviderChain::GetAWSCredentials()
         AWSCredentials credentials = credentialsProvider->GetAWSCredentials();
         if (!credentials.GetAWSAccessKeyId().empty() && !credentials.GetAWSSecretKey().empty())
         {
+            // TODO: issue of only chain, not overidden
+            // which credentials were used -- add it somethow
+            // request.addFeatureTrack(credential_type)
             m_cachedProvider = credentialsProvider;
             return credentials;
         }

src/aws-cpp-sdk-core/source/auth/signer/AWSAuthV4Signer.cpp

@@ -593,5 +593,5 @@ Aws::Utils::ByteBuffer AWSAuthV4Signer::ComputeHash(const Aws::String& secretKey
 
 Aws::Auth::AWSCredentials AWSAuthV4Signer::GetCredentials(const std::shared_ptr<Aws::Http::ServiceSpecificParameters> &serviceSpecificParameters) const {
     AWS_UNREFERENCED_PARAM(serviceSpecificParameters);
-    return m_credentialsProvider->GetAWSCredentials();
+    return m_credentialsProvider->GetAWSCredentials();//
 }

tests/aws-cpp-sdk-core-tests/aws/auth/CredentialTrackingTest.cpp

@@ -45,8 +45,8 @@ class CredentialTrackingTest : public Aws::Testing::AwsCppSdkGTestSuite
 TEST_F(CredentialTrackingTest, TestEnvironmentCredentialsTracking)
 {
     // Set environment variables
-    Aws::Environment::SetEnv("AWS_ACCESS_KEY_ID", "test-access-key");
-    Aws::Environment::SetEnv("AWS_SECRET_ACCESS_KEY", "test-secret-key");
+    Aws::Environment::SetEnv("AWS_ACCESS_KEY_ID", "test-access-key", 1);
+    Aws::Environment::SetEnv("AWS_SECRET_ACCESS_KEY", "test-secret-key", 1);
 
     // Setup mock response
     auto request = CreateHttpRequest(Aws::Http::URI("http://test.com"), 
@@ -88,4 +88,13 @@ TEST_F(CredentialTrackingTest, TestEnvironmentCredentialsTracking)
     // Clean up environment variables
     Aws::Environment::UnSetEnv("AWS_ACCESS_KEY_ID");
     Aws::Environment::UnSetEnv("AWS_SECRET_ACCESS_KEY");
+}
+
+TEST_F(CredentialTrackingTest, TestEnvironmentProviderType)
+{
+    // Test that EnvironmentAWSCredentialsProvider has correct provider type
+    auto envProvider = Aws::MakeShared<EnvironmentAWSCredentialsProvider>(ALLOCATION_TAG);
+    
+    // Verify the provider type is set correctly
+    EXPECT_EQ(envProvider->GetProviderType(), Aws::Auth::CredentialProviderType::ENVIRONMENT);
 }