refactoring ChecksumValidatingStreamBuf to separate files

Author: pulimsr

src/aws-cpp-sdk-transfer/include/aws/transfer/ChecksumValidatingStreamBuf.h

@@ -0,0 +1,38 @@
+/**
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0.
+ */
+
+#pragma once
+
+#include <aws/transfer/Transfer_EXPORTS.h>
+#include <aws/core/utils/crypto/Hash.h>
+#include <memory>
+#include <streambuf>
+
+namespace Aws
+{
+    namespace Transfer
+    {
+        /**
+         * Stream buffer wrapper that calculates checksum while forwarding data to underlying stream.
+         * Used for single-part download checksum validation.
+         */
+        class AWS_TRANSFER_API ChecksumValidatingStreamBuf : public std::streambuf
+        {
+        public:
+            ChecksumValidatingStreamBuf(std::streambuf* underlyingBuf, 
+                                        std::shared_ptr<Aws::Utils::Crypto::Hash> hash);
+
+            std::shared_ptr<Aws::Utils::Crypto::Hash> GetHash() const { return m_hash; }
+
+        protected:
+            std::streamsize xsputn(const char* s, std::streamsize n) override;
+            int overflow(int c) override;
+
+        private:
+            std::streambuf* m_underlyingBuf;
+            std::shared_ptr<Aws::Utils::Crypto::Hash> m_hash;
+        };
+    }
+}

src/aws-cpp-sdk-transfer/include/aws/transfer/TransferHandle.h

@@ -6,6 +6,7 @@
 #pragma once
 
 #include <aws/transfer/Transfer_EXPORTS.h>
+#include <aws/transfer/ChecksumValidatingStreamBuf.h>
 #include <aws/core/utils/memory/stl/AWSString.h>
 #include <aws/core/utils/memory/stl/AWSSet.h>
 #include <aws/core/utils/memory/stl/AWSMap.h>
@@ -102,42 +103,6 @@ namespace Aws
         using PartPointer = std::shared_ptr< PartState >;
         using PartStateMap = Aws::Map< int, PartPointer >;
 
-        /**
-         * Stream buffer wrapper that calculates checksum while forwarding data to underlying stream.
-         * Used for single-part download checksum validation.
-         */
-        class AWS_TRANSFER_API ChecksumValidatingStreamBuf : public std::streambuf
-        {
-        public:
-            ChecksumValidatingStreamBuf(std::streambuf* underlyingBuf, 
-                                        std::shared_ptr<Aws::Utils::Crypto::Hash> hash)
-                : m_underlyingBuf(underlyingBuf), m_hash(hash) {}
-            
-            std::shared_ptr<Aws::Utils::Crypto::Hash> GetHash() const { return m_hash; }
-
-        protected:
-            std::streamsize xsputn(const char* s, std::streamsize n) override
-            {
-                if (m_hash && n > 0) {
-                    m_hash->Update(const_cast<unsigned char*>(reinterpret_cast<const unsigned char*>(s)), static_cast<size_t>(n));
-                }
-                return m_underlyingBuf->sputn(s, n);
-            }
-
-            int overflow(int c) override
-            {
-                if (m_hash && c != EOF) {
-                    unsigned char byte = static_cast<unsigned char>(c);
-                    m_hash->Update(&byte, 1);
-                }
-                return m_underlyingBuf->sputc(c);
-            }
-
-        private:
-            std::streambuf* m_underlyingBuf;
-            std::shared_ptr<Aws::Utils::Crypto::Hash> m_hash;
-        };
-
         enum class TransferStatus
         {
             //this value is only used for directory synchronization

src/aws-cpp-sdk-transfer/source/transfer/ChecksumValidatingStreamBuf.cpp

@@ -0,0 +1,35 @@
+/**
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0.
+ */
+
+#include <aws/transfer/ChecksumValidatingStreamBuf.h>
+
+namespace Aws
+{
+    namespace Transfer
+    {
+        ChecksumValidatingStreamBuf::ChecksumValidatingStreamBuf(std::streambuf* underlyingBuf, 
+                                                                 std::shared_ptr<Aws::Utils::Crypto::Hash> hash)
+            : m_underlyingBuf(underlyingBuf), m_hash(hash)
+        {
+        }
+
+        std::streamsize ChecksumValidatingStreamBuf::xsputn(const char* s, std::streamsize n)
+        {
+            if (m_hash && n > 0) {
+                m_hash->Update(const_cast<unsigned char*>(reinterpret_cast<const unsigned char*>(s)), static_cast<size_t>(n));
+            }
+            return m_underlyingBuf->sputn(s, n);
+        }
+
+        int ChecksumValidatingStreamBuf::overflow(int c)
+        {
+            if (c != EOF && m_hash) {
+                unsigned char byte = static_cast<unsigned char>(c);
+                m_hash->Update(&byte, 1);
+            }
+            return m_underlyingBuf->sputc(c);
+        }
+    }
+}