Skip to content

Commit 9bd690a

Browse files
committed
skip flaky windows test
1 parent 9bbd534 commit 9bd690a

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

tests/aws-cpp-sdk-core-tests/aws/auth/GeneralHTTPCredentialsProviderTest.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@
1313
#include <aws/core/platform/Environment.h>
1414
#include <aws/core/platform/FileSystem.h>
1515

16+
#if defined(_WIN32)
17+
// disable "warning C4702: unreachable code" from GTEST_SKIP on newer MSVS
18+
#pragma warning(disable: 4702)
19+
#endif
20+
1621
static const char ALLOCATION_TAG[] = "GeneralHTTPCredentialsProviderTest";
1722

1823
using namespace Aws::Auth;
@@ -472,6 +477,10 @@ using GeneralHTTPCredentialsProviderResponseHandlingTests = GeneralHTTPCredentia
472477

473478
TEST_P(GeneralHTTPCredentialsProviderResponseHandlingTests, ResponseHandlingTest)
474479
{
480+
#ifdef _WIN32
481+
//TODO: once in a while this test is flaky in our CI, we need to do a deeper investigation.
482+
GTEST_SKIP() << "Skipping http provider test for windows";
483+
#endif
475484
Aws::Utils::Json::JsonValue TEST_CASES(RH_TEST_CASES);
476485
ASSERT_TRUE(TEST_CASES.WasParseSuccessful());
477486
ASSERT_EQ(RH_TEST_CASES_COUNT, TEST_CASES.View().AsArray().GetLength());

0 commit comments

Comments
 (0)