Skip to content

Commit 9d67d27

Browse files
committed
Fix 'hides overloaded virtual function' error
1 parent 268bb54 commit 9d67d27

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/aws-cpp-sdk-core/include/smithy/client/common/AwsSmithyRequestSigning.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ namespace smithy
281281
false/*retryable*/));
282282
return;
283283
}
284-
result.emplace(signer->sign(m_message, m_seed, *static_cast<IdentityT*>(m_requestContext->m_awsIdentity.get()),
284+
result.emplace(signer->signMessage(m_message, m_seed, *static_cast<IdentityT*>(m_requestContext->m_awsIdentity.get()),
285285
m_requestContext->m_authSchemeOption.signerProperties()));
286286
}
287287
};

src/aws-cpp-sdk-core/include/smithy/identity/signer/AwsSignerBase.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ namespace smithy {
4949
// signer may copy the original httpRequest or create a new one
5050
virtual SigningFutureOutcome sign(std::shared_ptr<HttpRequest> httpRequest, const IdentityT& identity, SigningProperties properties) = 0;
5151
virtual SigningFutureOutcome presign(std::shared_ptr<HttpRequest> httpRequest, const IdentityT& identity, SigningProperties properties, const Aws::String& region, const Aws::String& serviceName, long long expirationTimeInSeconds) = 0;
52-
virtual SigningEventOutcome sign(Aws::Utils::Event::Message&, Aws::String&, const IdentityT&, SigningProperties) { return SigningError(Aws::Client::CoreErrors::CLIENT_SIGNING_FAILURE, "", "Failed to sign with a signer that doesn't support signing event messages", false /*retryable*/); };
52+
virtual SigningEventOutcome signMessage(Aws::Utils::Event::Message&, Aws::String&, const IdentityT&, SigningProperties) { return SigningError(Aws::Client::CoreErrors::CLIENT_SIGNING_FAILURE, "", "Failed to sign with a signer that doesn't support signing event messages", false /*retryable*/); };
5353

5454
virtual ~AwsSignerBase() {};
5555
};

src/aws-cpp-sdk-core/include/smithy/identity/signer/built-in/SigV4Signer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ namespace smithy {
9595
false /*retryable*/));
9696
}
9797

98-
SigningEventOutcome sign(Aws::Utils::Event::Message& msg, Aws::String& seed, const AwsCredentialIdentityBase& identity, SigningProperties properties) override {
98+
SigningEventOutcome signMessage(Aws::Utils::Event::Message& msg, Aws::String& seed, const AwsCredentialIdentityBase& identity, SigningProperties properties) override {
9999
AWS_UNREFERENCED_PARAM(properties);
100100
const auto legacyCreds = [&identity]() -> Aws::Auth::AWSCredentials {
101101
if(identity.sessionToken().has_value() && identity.expiration().has_value())

0 commit comments

Comments
 (0)