fix GetBool in Document

Author: sbiscigl

src/aws-cpp-sdk-core/source/utils/Document.cpp

@@ -449,7 +449,7 @@ bool DocumentView::GetBool(const Aws::String& key) const
     assert(m_json);
     auto item = cJSON_AS4CPP_GetObjectItemCaseSensitive(m_json, key.c_str());
     assert(item);
-    return item->valueint != 0;
+    return item->type == cJSON_AS4CPP_True;
 }
 
 bool DocumentView::AsBool() const

tests/aws-cpp-sdk-core-tests/utils/DocumentTest.cpp

@@ -637,3 +637,13 @@ TEST_F(DocumentTest, TestEquality)
     built.WithString("AWS", "Amazon Web Services");
     ASSERT_NE(parsed, built);
 }
+
+TEST_F(DocumentTest, TestBooleanTrue)
+{
+  const auto doc = Document{}
+    .WithBool("time_marches_on", true)
+    .WithBool("and_the_age_of_a_new_king_draws_near", false);
+
+  ASSERT_TRUE(doc.View().GetBool("time_marches_on"));
+  ASSERT_FALSE(doc.View().GetBool("and_the_age_of_a_new_king_draws_near"));
+}