Update smoke tests for error logging on failures (#3656)

sbaluja · web-flow · commit e1b34b6f83ce · 2025-12-18T12:07:45.000-05:00
diff --git a/generated/smoke-tests/apigateway/APIGatewaySmokeTests.cpp b/generated/smoke-tests/apigateway/APIGatewaySmokeTests.cpp
@@ -41,6 +41,6 @@ TEST_F(APIGatewaySmokeTestSuite, GetDomainNamesSuccess )
     
     GetDomainNamesRequest input;
     auto outcome = clientSp->GetDomainNames(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/application-autoscaling/ApplicationAutoScalingSmokeTests.cpp b/generated/smoke-tests/application-autoscaling/ApplicationAutoScalingSmokeTests.cpp
@@ -42,6 +42,6 @@ TEST_F(ApplicationAutoScalingSmokeTestSuite, DescribeScalableTargetsSuccess )
     DescribeScalableTargetsRequest input;
     input.SetServiceNamespace(ServiceNamespace::ec2);
     auto outcome = clientSp->DescribeScalableTargets(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/cloudhsmv2/CloudHSMV2SmokeTests.cpp b/generated/smoke-tests/cloudhsmv2/CloudHSMV2SmokeTests.cpp
@@ -41,6 +41,6 @@ TEST_F(CloudHSMV2SmokeTestSuite, DescribeClustersSuccess )
     
     DescribeClustersRequest input;
     auto outcome = clientSp->DescribeClusters(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/cognito-idp/CognitoIdentityProviderSmokeTests.cpp b/generated/smoke-tests/cognito-idp/CognitoIdentityProviderSmokeTests.cpp
@@ -42,6 +42,6 @@ TEST_F(CognitoIdentityProviderSmokeTestSuite, ListUserPoolsSuccess )
     ListUserPoolsRequest input;
     input.SetMaxResults(10);
     auto outcome = clientSp->ListUserPools(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/config/ConfigServiceSmokeTests.cpp b/generated/smoke-tests/config/ConfigServiceSmokeTests.cpp
@@ -41,6 +41,6 @@ TEST_F(ConfigServiceSmokeTestSuite, DescribeConfigurationRecordersSuccess )
     
     DescribeConfigurationRecordersRequest input;
     auto outcome = clientSp->DescribeConfigurationRecorders(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/cur/CostandUsageReportServiceSmokeTests.cpp b/generated/smoke-tests/cur/CostandUsageReportServiceSmokeTests.cpp
@@ -41,6 +41,6 @@ TEST_F(CostandUsageReportServiceSmokeTestSuite, DescribeReportDefinitionsSuccess
     
     DescribeReportDefinitionsRequest input;
     auto outcome = clientSp->DescribeReportDefinitions(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/directconnect/DirectConnectSmokeTests.cpp b/generated/smoke-tests/directconnect/DirectConnectSmokeTests.cpp
@@ -42,7 +42,7 @@ TEST_F(DirectConnectSmokeTestSuite, DescribeConnectionsSuccess )
     
     DescribeConnectionsRequest input;
     auto outcome = clientSp->DescribeConnections(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 TEST_F(DirectConnectSmokeTestSuite, DescribeConnectionsFailure )
 {
diff --git a/generated/smoke-tests/discovery/ApplicationDiscoveryServiceSmokeTests.cpp b/generated/smoke-tests/discovery/ApplicationDiscoveryServiceSmokeTests.cpp
@@ -41,6 +41,6 @@ TEST_F(ApplicationDiscoveryServiceSmokeTestSuite, DescribeAgentsSuccess )
     
     DescribeAgentsRequest input;
     auto outcome = clientSp->DescribeAgents(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/dms/DatabaseMigrationServiceSmokeTests.cpp b/generated/smoke-tests/dms/DatabaseMigrationServiceSmokeTests.cpp
@@ -41,6 +41,6 @@ TEST_F(DatabaseMigrationServiceSmokeTestSuite, DescribeEndpointsSuccess )
     
     DescribeEndpointsRequest input;
     auto outcome = clientSp->DescribeEndpoints(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/ds/DirectoryServiceSmokeTests.cpp b/generated/smoke-tests/ds/DirectoryServiceSmokeTests.cpp
@@ -41,6 +41,6 @@ TEST_F(DirectoryServiceSmokeTestSuite, DescribeDirectoriesSuccess )
     
     DescribeDirectoriesRequest input;
     auto outcome = clientSp->DescribeDirectories(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/elasticfilesystem/EFSSmokeTests.cpp b/generated/smoke-tests/elasticfilesystem/EFSSmokeTests.cpp
@@ -41,6 +41,6 @@ TEST_F(EFSSmokeTestSuite, DescribeFileSystemsSuccess )
     
     DescribeFileSystemsRequest input;
     auto outcome = clientSp->DescribeFileSystems(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/elasticloadbalancing/ElasticLoadBalancingSmokeTests.cpp b/generated/smoke-tests/elasticloadbalancing/ElasticLoadBalancingSmokeTests.cpp
@@ -42,7 +42,7 @@ TEST_F(ElasticLoadBalancingSmokeTestSuite, DescribeLoadBalancersSuccess )
     
     DescribeLoadBalancersRequest input;
     auto outcome = clientSp->DescribeLoadBalancers(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 TEST_F(ElasticLoadBalancingSmokeTestSuite, DescribeLoadBalancersFailure )
 {
diff --git a/generated/smoke-tests/elasticmapreduce/EMRSmokeTests.cpp b/generated/smoke-tests/elasticmapreduce/EMRSmokeTests.cpp
@@ -56,6 +56,6 @@ TEST_F(EMRSmokeTestSuite, ListClustersSuccess )
     
     ListClustersRequest input;
     auto outcome = clientSp->ListClusters(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/email/SESSmokeTests.cpp b/generated/smoke-tests/email/SESSmokeTests.cpp
@@ -41,6 +41,6 @@ TEST_F(SESSmokeTestSuite, ListIdentitiesSuccess )
     
     ListIdentitiesRequest input;
     auto outcome = clientSp->ListIdentities(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/logs/CloudWatchLogsSmokeTests.cpp b/generated/smoke-tests/logs/CloudWatchLogsSmokeTests.cpp
@@ -43,7 +43,7 @@ TEST_F(CloudWatchLogsSmokeTestSuite, DescribeLogGroupsSuccess )
     
     DescribeLogGroupsRequest input;
     auto outcome = clientSp->DescribeLogGroups(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 TEST_F(CloudWatchLogsSmokeTestSuite, GetLogEventsFailure )
 {
diff --git a/generated/smoke-tests/monitoring/CloudWatchSmokeTests.cpp b/generated/smoke-tests/monitoring/CloudWatchSmokeTests.cpp
@@ -43,6 +43,6 @@ TEST_F(CloudWatchSmokeTestSuite, ListMetricsSuccess )
     ListMetricsRequest input;
     input.SetNamespace("AWS/EC2");
     auto outcome = clientSp->ListMetrics(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/route53/Route53SmokeTests.cpp b/generated/smoke-tests/route53/Route53SmokeTests.cpp
@@ -56,6 +56,6 @@ TEST_F(Route53SmokeTestSuite, ListHostedZonesSuccess )
     
     ListHostedZonesRequest input;
     auto outcome = clientSp->ListHostedZones(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/route53domains/Route53DomainsSmokeTests.cpp b/generated/smoke-tests/route53domains/Route53DomainsSmokeTests.cpp
@@ -56,6 +56,6 @@ TEST_F(Route53DomainsSmokeTestSuite, ListDomainsSuccess )
     
     ListDomainsRequest input;
     auto outcome = clientSp->ListDomains(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/secretsmanager/SecretsManagerSmokeTests.cpp b/generated/smoke-tests/secretsmanager/SecretsManagerSmokeTests.cpp
@@ -56,6 +56,6 @@ TEST_F(SecretsManagerSmokeTestSuite, ListSecretsSuccess )
     
     ListSecretsRequest input;
     auto outcome = clientSp->ListSecrets(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/generated/smoke-tests/states/SFNSmokeTests.cpp b/generated/smoke-tests/states/SFNSmokeTests.cpp
@@ -41,6 +41,6 @@ TEST_F(SFNSmokeTestSuite, ListActivitiesSuccess )
     
     ListActivitiesRequest input;
     auto outcome = clientSp->ListActivities(input);
-    EXPECT_TRUE( outcome.IsSuccess());
+    EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();
 }
 }
diff --git a/tools/code-generation/smithy/codegen/cpp-smoke-tests-codegen/src/main/java/com/amazonaws/util/awsclientsmithygenerator/generators/SmokeTestsSourceWriter.java b/tools/code-generation/smithy/codegen/cpp-smoke-tests-codegen/src/main/java/com/amazonaws/util/awsclientsmithygenerator/generators/SmokeTestsSourceWriter.java
@@ -81,7 +81,7 @@ protected void defineTestCase(SmokeTestData test)
         write("auto outcome = clientSp->$L(input);",test.getOperationName());
         if (test.isExpectSuccess())
         {
-            write("EXPECT_TRUE( outcome.IsSuccess());");
+            write("EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << \" - \" << outcome.GetError().GetMessage();");
         }
         else
         {

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,6 @@ TEST_F(APIGatewaySmokeTestSuite, GetDomainNamesSuccess )`
`41`	`41`
`42`	`42`	`GetDomainNamesRequest input;`
`43`	`43`	`auto outcome = clientSp->GetDomainNames(input);`
`44`		`- EXPECT_TRUE( outcome.IsSuccess());`
	`44`	`+ EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();`
`45`	`45`	`}`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,6 @@ TEST_F(ApplicationAutoScalingSmokeTestSuite, DescribeScalableTargetsSuccess )`
`42`	`42`	`DescribeScalableTargetsRequest input;`
`43`	`43`	`input.SetServiceNamespace(ServiceNamespace::ec2);`
`44`	`44`	`auto outcome = clientSp->DescribeScalableTargets(input);`
`45`		`- EXPECT_TRUE( outcome.IsSuccess());`
	`45`	`+ EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();`
`46`	`46`	`}`
`47`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,6 @@ TEST_F(CloudHSMV2SmokeTestSuite, DescribeClustersSuccess )`
`41`	`41`
`42`	`42`	`DescribeClustersRequest input;`
`43`	`43`	`auto outcome = clientSp->DescribeClusters(input);`
`44`		`- EXPECT_TRUE( outcome.IsSuccess());`
	`44`	`+ EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();`
`45`	`45`	`}`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,6 @@ TEST_F(CognitoIdentityProviderSmokeTestSuite, ListUserPoolsSuccess )`
`42`	`42`	`ListUserPoolsRequest input;`
`43`	`43`	`input.SetMaxResults(10);`
`44`	`44`	`auto outcome = clientSp->ListUserPools(input);`
`45`		`- EXPECT_TRUE( outcome.IsSuccess());`
	`45`	`+ EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();`
`46`	`46`	`}`
`47`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,6 @@ TEST_F(ConfigServiceSmokeTestSuite, DescribeConfigurationRecordersSuccess )`
`41`	`41`
`42`	`42`	`DescribeConfigurationRecordersRequest input;`
`43`	`43`	`auto outcome = clientSp->DescribeConfigurationRecorders(input);`
`44`		`- EXPECT_TRUE( outcome.IsSuccess());`
	`44`	`+ EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();`
`45`	`45`	`}`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,6 @@ TEST_F(CostandUsageReportServiceSmokeTestSuite, DescribeReportDefinitionsSuccess`
`41`	`41`
`42`	`42`	`DescribeReportDefinitionsRequest input;`
`43`	`43`	`auto outcome = clientSp->DescribeReportDefinitions(input);`
`44`		`- EXPECT_TRUE( outcome.IsSuccess());`
	`44`	`+ EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();`
`45`	`45`	`}`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ TEST_F(DirectConnectSmokeTestSuite, DescribeConnectionsSuccess )`
`42`	`42`
`43`	`43`	`DescribeConnectionsRequest input;`
`44`	`44`	`auto outcome = clientSp->DescribeConnections(input);`
`45`		`- EXPECT_TRUE( outcome.IsSuccess());`
	`45`	`+ EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();`
`46`	`46`	`}`
`47`	`47`	`TEST_F(DirectConnectSmokeTestSuite, DescribeConnectionsFailure )`
`48`	`48`	`{`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,6 @@ TEST_F(ApplicationDiscoveryServiceSmokeTestSuite, DescribeAgentsSuccess )`
`41`	`41`
`42`	`42`	`DescribeAgentsRequest input;`
`43`	`43`	`auto outcome = clientSp->DescribeAgents(input);`
`44`		`- EXPECT_TRUE( outcome.IsSuccess());`
	`44`	`+ EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();`
`45`	`45`	`}`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,6 @@ TEST_F(DatabaseMigrationServiceSmokeTestSuite, DescribeEndpointsSuccess )`
`41`	`41`
`42`	`42`	`DescribeEndpointsRequest input;`
`43`	`43`	`auto outcome = clientSp->DescribeEndpoints(input);`
`44`		`- EXPECT_TRUE( outcome.IsSuccess());`
	`44`	`+ EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();`
`45`	`45`	`}`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,6 @@ TEST_F(DirectoryServiceSmokeTestSuite, DescribeDirectoriesSuccess )`
`41`	`41`
`42`	`42`	`DescribeDirectoriesRequest input;`
`43`	`43`	`auto outcome = clientSp->DescribeDirectories(input);`
`44`		`- EXPECT_TRUE( outcome.IsSuccess());`
	`44`	`+ EXPECT_TRUE( outcome.IsSuccess()) << outcome.GetError().GetExceptionName() << " - " << outcome.GetError().GetMessage();`
`45`	`45`	`}`
`46`	`46`	`}`