Build is failing after submodule s2n rename?

[bazookanu]

Describe the bug

Worked around by hardcoding submodule repo:
git clone --recurse-submodules --depth 1 --shallow-submodules https://github.com/aws/aws-sdk-cpp.git /tmp/aws-sdk-cpp
&& cd /tmp/aws-sdk-cpp
&& git submodule init
&& git config submodule.crt/aws-crt-cpp/crt/s2n.url https://github.com/aws/s2n-tls.git
&& mkdir -p /tmp/aws-sdk-cpp-build
&& cd /tmp/aws-sdk-cpp-build
&& cmake -DCMAKE_BUILD_TYPE=Release
-DBUILD_ONLY="s3;monitoring"
-DCMAKE_INSTALL_PREFIX=/usr
-DENABLE_TESTING=OFF
-DAUTORUN_UNIT_TESTS=OFF
-DENABLE_UNITY_BUILD=ON
-DMINIMIZE_SIZE=ON
-DSIMPLE_INSTALL=ON
/tmp/aws-sdk-cpp
&& make -j$(nproc)
&& make install
&& rm -rf /tmp/aws-sdk-cpp /tmp/aws-sdk-cpp-build

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

git clone --recurse-submodules --depth 1 --shallow-submodules https://github.com/aws/aws-sdk-cpp.git /tmp/aws-sdk-cpp     && mkdir -p /tmp/aws-sdk-cpp-build     && cd /tmp/aws-sdk-cpp-build     && cmake -DCMAKE_BUILD_TYPE=Release              -DBUILD_ONLY="s3;monitoring"              -DCMAKE_INSTALL_PREFIX=/usr              -DENABLE_TESTING=OFF              -DAUTORUN_UNIT_TESTS=OFF              -DENABLE_UNITY_BUILD=ON              -DMINIMIZE_SIZE=ON              -DSIMPLE_INSTALL=ON              /tmp/aws-sdk-cpp     && make -j$(nproc)     && make install     && rm -rf /tmp/aws-sdk-cpp /tmp/aws-sdk-cpp-build

should work

Current Behavior

Build fails

 > [ 3/17] RUN git clone --recurse-submodules --depth 1 --shallow-submodules https://github.com/aws/aws-sdk-cpp.git /tmp/aws-sdk-cpp     && mkdir -p /tmp/aws-sdk-cpp-build     && cd /tmp/aws-sdk-cpp-build     && cmake -DCMAKE_BUILD_TYPE=Release              -DBUILD_ONLY="s3;monitoring"              -DCMAKE_INSTALL_PREFIX=/usr              -DENABLE_TESTING=OFF              -DAUTORUN_UNIT_TESTS=OFF              -DENABLE_UNITY_BUILD=ON              -DMINIMIZE_SIZE=ON              -DSIMPLE_INSTALL=ON              /tmp/aws-sdk-cpp     && make -j$(nproc)     && make install     && rm -rf /tmp/aws-sdk-cpp /tmp/aws-sdk-cpp-build:
0.199 Cloning into '/tmp/aws-sdk-cpp'...
Updating files: 100% (144645/144645), done.
28.33 Submodule 'aws-common-runtime/aws-crt-cpp' (https://github.com/awslabs/aws-crt-cpp.git) registered for path 'crt/aws-crt-cpp'
28.33 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp'...
29.62 Submodule path 'crt/aws-crt-cpp': checked out 'e42a4471c9e49692a806073605c56bf36fdc740c'
29.62 Submodule 'crt/aws-c-auth' (https://github.com/awslabs/aws-c-auth.git) registered for path 'crt/aws-crt-cpp/crt/aws-c-auth'
29.63 Submodule 'crt/aws-c-cal' (https://github.com/awslabs/aws-c-cal.git) registered for path 'crt/aws-crt-cpp/crt/aws-c-cal'
29.63 Submodule 'crt/aws-c-common' (https://github.com/awslabs/aws-c-common.git) registered for path 'crt/aws-crt-cpp/crt/aws-c-common'
29.63 Submodule 'crt/aws-c-compression' (https://github.com/awslabs/aws-c-compression.git) registered for path 'crt/aws-crt-cpp/crt/aws-c-compression'
29.63 Submodule 'crt/aws-c-event-stream' (https://github.com/awslabs/aws-c-event-stream.git) registered for path 'crt/aws-crt-cpp/crt/aws-c-event-stream'
29.63 Submodule 'crt/aws-c-http' (https://github.com/awslabs/aws-c-http.git) registered for path 'crt/aws-crt-cpp/crt/aws-c-http'
29.63 Submodule 'crt/aws-c-io' (https://github.com/awslabs/aws-c-io.git) registered for path 'crt/aws-crt-cpp/crt/aws-c-io'
29.63 Submodule 'crt/aws-c-mqtt' (https://github.com/awslabs/aws-c-mqtt.git) registered for path 'crt/aws-crt-cpp/crt/aws-c-mqtt'
29.63 Submodule 'crt/aws-c-s3' (https://github.com/awslabs/aws-c-s3.git) registered for path 'crt/aws-crt-cpp/crt/aws-c-s3'
29.63 Submodule 'crt/aws-c-sdkutils' (https://github.com/awslabs/aws-c-sdkutils.git) registered for path 'crt/aws-crt-cpp/crt/aws-c-sdkutils'
29.63 Submodule 'crt/aws-checksums' (https://github.com/awslabs/aws-checksums.git) registered for path 'crt/aws-crt-cpp/crt/aws-checksums'
29.63 Submodule 'crt/aws-lc' (https://github.com/awslabs/aws-lc.git) registered for path 'crt/aws-crt-cpp/crt/aws-lc'
29.63 Submodule 'crt/s2n' (https://github.com/awslabs/s2n.git) registered for path 'crt/aws-crt-cpp/crt/s2n'
29.64 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-auth'...
30.93 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-cal'...
33.08 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-common'...
34.33 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-compression'...
35.29 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-event-stream'...
36.29 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-http'...
37.31 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-io'...
38.46 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-mqtt'...
84.56 fatal: unable to access 'https://github.com/awslabs/aws-c-mqtt.git/': gnutls_handshake() failed: The TLS connection was non-properly terminated.
84.57 fatal: clone of 'https://github.com/awslabs/aws-c-mqtt.git' into submodule path '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-mqtt' failed
84.57 Failed to clone 'crt/aws-c-mqtt'. Retry scheduled
84.57 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-s3'...
85.81 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-sdkutils'...
86.97 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-checksums'...
162.0 fatal: unable to access 'https://github.com/awslabs/aws-checksums.git/': Failed to connect to github.com port 443 after 75007 ms: Couldn't connect to server
162.0 fatal: clone of 'https://github.com/awslabs/aws-checksums.git' into submodule path '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-checksums' failed
162.0 Failed to clone 'crt/aws-checksums'. Retry scheduled
162.0 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-lc'...
172.1 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n'...
173.9 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-mqtt'...
175.0 Cloning into '/tmp/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-checksums'...
176.1 Submodule path 'crt/aws-crt-cpp/crt/aws-c-auth': checked out 'ab03bdd996437d9097953ebb9495de71b6adc537'
176.1 Submodule path 'crt/aws-crt-cpp/crt/aws-c-cal': checked out 'a94346d7b661875f71dd93a9664d54b2e06535dc'
178.5 From https://github.com/awslabs/aws-c-common
178.5  * branch            31578beb2309330fece3fb3a66035a568a2641e7 -> FETCH_HEAD
178.6 Submodule path 'crt/aws-crt-cpp/crt/aws-c-common': checked out '31578beb2309330fece3fb3a66035a568a2641e7'
180.5 From https://github.com/awslabs/aws-c-compression
180.5  * branch            f951ab2b819fc6993b6e5e6cfef64b1a1554bfc8 -> FETCH_HEAD
180.6 Submodule path 'crt/aws-crt-cpp/crt/aws-c-compression': checked out 'f951ab2b819fc6993b6e5e6cfef64b1a1554bfc8'
180.6 Submodule path 'crt/aws-crt-cpp/crt/aws-c-event-stream': checked out '31a44ff9108840a8f3fec54006218f4bc6c505e1'
182.8 From https://github.com/awslabs/aws-c-http
182.8  * branch            bbfc5a7bcf1a6c238205abcac62d5d14dd0da7ef -> FETCH_HEAD
182.8 Submodule path 'crt/aws-crt-cpp/crt/aws-c-http': checked out 'bbfc5a7bcf1a6c238205abcac62d5d14dd0da7ef'
182.8 Submodule path 'crt/aws-crt-cpp/crt/aws-c-io': checked out '1af325b54bba2e95a640a5be5ffe0b27e4ead79c'
184.6 From https://github.com/awslabs/aws-c-mqtt
184.6  * branch            1d512d92709f60b74e2cafa018e69a2e647f28e9 -> FETCH_HEAD
184.7 Submodule path 'crt/aws-crt-cpp/crt/aws-c-mqtt': checked out '1d512d92709f60b74e2cafa018e69a2e647f28e9'
186.8 From https://github.com/awslabs/aws-c-s3
186.8  * branch            332dd22c47a7ed139eee71e7f219b764ef8cdf4c -> FETCH_HEAD
186.8 Submodule path 'crt/aws-crt-cpp/crt/aws-c-s3': checked out '332dd22c47a7ed139eee71e7f219b764ef8cdf4c'
189.0 From https://github.com/awslabs/aws-c-sdkutils
189.0  * branch            f678bda9e21f7217e4bbf35e0d1ea59540687933 -> FETCH_HEAD
189.0 Submodule path 'crt/aws-crt-cpp/crt/aws-c-sdkutils': checked out 'f678bda9e21f7217e4bbf35e0d1ea59540687933'
190.9 From https://github.com/awslabs/aws-checksums
190.9  * branch            9978ba2c33a7a259c1a6bd0f62abe26827d03b85 -> FETCH_HEAD
190.9 Submodule path 'crt/aws-crt-cpp/crt/aws-checksums': checked out '9978ba2c33a7a259c1a6bd0f62abe26827d03b85'
193.4 From https://github.com/awslabs/aws-lc
193.4  * branch            5a9df2190d9ecab090a62030f94a6ada6789a436 -> FETCH_HEAD
194.2 Submodule path 'crt/aws-crt-cpp/crt/aws-lc': checked out '5a9df2190d9ecab090a62030f94a6ada6789a436'
250.6 fatal: unable to access 'https://github.com/awslabs/s2n.git/': gnutls_handshake() failed: The TLS connection was non-properly terminated.
250.6 fatal: Fetched in submodule path 'crt/aws-crt-cpp/crt/s2n', but it did not contain 30f40f2345a89570ed3c4cee2274942f1ebf85fa. Direct fetching of that commit failed.
250.6 fatal: Failed to recurse into submodule path 'crt/aws-crt-cpp'

Reproduction Steps

Run

git clone --recurse-submodules --depth 1 --shallow-submodules https://github.com/aws/aws-sdk-cpp.git /tmp/aws-sdk-cpp     && mkdir -p /tmp/aws-sdk-cpp-build     && cd /tmp/aws-sdk-cpp-build     && cmake -DCMAKE_BUILD_TYPE=Release              -DBUILD_ONLY="s3;monitoring"              -DCMAKE_INSTALL_PREFIX=/usr              -DENABLE_TESTING=OFF              -DAUTORUN_UNIT_TESTS=OFF              -DENABLE_UNITY_BUILD=ON              -DMINIMIZE_SIZE=ON              -DSIMPLE_INSTALL=ON              /tmp/aws-sdk-cpp     && make -j$(nproc)     && make install     && rm -rf /tmp/aws-sdk-cpp /tmp/aws-sdk-cpp-build

Possible Solution

No response

Additional Information/Context

No response

AWS CPP SDK version used

latest

Compiler and Version used

13.2

Operating System and version

ubuntu 24.04

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.