Updates SDK for Go 1.17 (#1381)

* Updates SDK's `build` tags to use go 1.17's formatting style of `// go:build ...`.
* Updates Makefile's sandbox test statements to use common pattern instead of individually defined.
* Updates CI for Go 1.17.

Author: jasdel

.github/workflows/codegen.yml

@@ -14,7 +14,7 @@ jobs:
       matrix:
         os: [ubuntu-latest]
         java-version: ['11', '8']
-        go-version: [1.16]
+        go-version: [1.17]
     env:
       JAVA_TOOL_OPTIONS: "-Xmx2g"
     steps:

.github/workflows/go.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest]
-        go-version: [1.16, 1.15]
+        go-version: [1.17, 1.16, 1.15]
     steps:
     - uses: actions/checkout@v2
 
@@ -34,7 +34,7 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest]
-        go-version: [1.16, 1.15]
+        go-version: [1.17, 1.16, 1.15]
     env:
       EACHMODULE_SKIP: "internal\\repotools\\changes"
     steps:

.github/workflows/golangci-lint.yml

@@ -11,16 +11,18 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        go-version: [1.16.x]
+        go-version: [1.17.x]
         os: [ubuntu-latest]  # other options: macos-latest, windows-latest
     steps:
       - uses: actions/checkout@v2
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v2
         with:
-          # Required: the version of golangci-lint is required and must be specified without patch version
+          # Required: the version of golangci-lint is required and must be
+          # specified without patch version
           version: latest
-          # the following causes golangci-init to do nothing, so all it does is install golang and golangci
+          # the following causes golangci-init to do nothing, so all it does is
+          # install golang and golangci
           args: --version
           # Show only new issues if it's a pull request. The default value is `false`.
           # only-new-issues: true

Makefile

@@ -442,32 +442,24 @@ sdkv1check:
 ###################
 # Sandbox Testing #
 ###################
-.PHONY: sandbox-tests sandbox-build-go1.15 sandbox-go1.15 sandbox-test-go1.15 sandbox-build-go1.16 \
-sandbox-go1.16 sandbox-test-go1.16 sandbox-build-gotip sandbox-gotip sandbox-test-gotip update-aws-golang-tip
-
-sandbox-tests: sandbox-test-go1.15 sandbox-test-go1.16 sandbox-test-gotip
-
-sandbox-build-go1.15:
-	docker build -f ./internal/awstesting/sandbox/Dockerfile.test.go1.15 -t "aws-sdk-go-v2-1.15" .
-sandbox-go1.15: sandbox-build-go1.15
-	docker run -i -t aws-sdk-go-v2-1.15 bash
-sandbox-test-go1.15: sandbox-build-go1.15
-	docker run -t aws-sdk-go-v2-1.15
-
-sandbox-build-go1.16:
-	docker build -f ./internal/awstesting/sandbox/Dockerfile.test.go1.16 -t "aws-sdk-go-v2-1.16" .
-sandbox-go1.16: sandbox-build-go1.16
-	docker run -i -t aws-sdk-go-v2-1.16 bash
-sandbox-test-go1.16: sandbox-build-go1.16
-	docker run -t aws-sdk-go-v2-1.16
-
-sandbox-build-gotip:
-	@echo "Run make update-aws-golang-tip, if this test fails because missing aws-golang:tip container"
-	docker build -f ./internal/awstesting/sandbox/Dockerfile.test.gotip -t "aws-sdk-go-v2-tip" .
-sandbox-gotip: sandbox-build-gotip
-	docker run -i -t aws-sdk-go-v2-tip bash
-sandbox-test-gotip: sandbox-build-gotip
-	docker run -t aws-sdk-go-v2-tip
+.PHONY: sandbox-tests sandbox-build-% sandbox-run-% sandbox-test-% update-aws-golang-tip
+
+sandbox-tests: sandbox-test-go1.15 sandbox-test-go1.16 sandbox-test-go1.17 sandbox-test-gotip
+
+sandbox-build-%:
+	@# sandbox-build-go1.17
+	@# sandbox-build-gotip
+	docker build \
+		-f ./internal/awstesting/sandbox/Dockerfile.test.$(subst sandbox-build-,,$@) \
+		-t "aws-sdk-go-$(subst sandbox-build-,,$@)" .
+sandbox-run-%: sandbox-build-%
+	@# sandbox-run-go1.17
+	@# sandbox-run-gotip
+	docker run -i -t "aws-sdk-go-$(subst sandbox-run-,,$@)" bash
+sandbox-test-%: sandbox-build-%
+	@# sandbox-test-go1.17
+	@# sandbox-test-gotip
+	docker run -t "aws-sdk-go-$(subst sandbox-test-,,$@)"
 
 update-aws-golang-tip:
 	docker build --no-cache=true -f ./internal/awstesting/sandbox/Dockerfile.golang-tip -t "aws-golang:tip" .

aws/generate.go

@@ -1,3 +1,4 @@
+//go:build ignore
 // +build ignore
 
 package main

aws/logging_generate.go

@@ -1,3 +1,4 @@
+//go:build clientlogmode
 // +build clientlogmode
 
 package main

aws/middleware/osname.go

@@ -1,3 +1,4 @@
+//go:build go1.16
 // +build go1.16
 
 package middleware

aws/middleware/osname_go115.go

@@ -1,3 +1,4 @@
+//go:build !go1.16
 // +build !go1.16
 
 package middleware

config/codegen/main.go

@@ -1,3 +1,4 @@
+//go:build codegen
 // +build codegen
 
 package main

config/shared_config_other_test.go

@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows
 
 package config