Skip to content

Commit 630afef

Browse files
skotambkarjasdel
authored andcommitted
private/model : Fixes generated API Reference docs links being invalid (#387)
SDK was generating incorrect api reference docs link; Fix includes changes to the go template used to generate service shapes. Fixes #327
1 parent 33a4306 commit 630afef

File tree

5,784 files changed

+12
-16201
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

5,784 files changed

+12
-16201
lines changed

CHANGELOG_PENDING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,7 @@
2929
* `service/s3` : Fixes unexpected EOF error by s3manager ([#386](https://github.com/aws/aws-sdk-go-v2/pull/386))
3030
* Fixes bug which threw unexpected EOF error when s3 upload is performed for a file of maximum allowed size
3131
* Fixes [#316](https://github.com/aws/aws-sdk-go-v2/issues/316)
32-
32+
* `private/model` : Fixes generated API Reference docs links being invalid ([387](https://github.com/aws/aws-sdk-go-v2/pull/387))
33+
* Fixes [#327](https://github.com/aws/aws-sdk-go-v2/issues/327)
34+
3335

private/model/api/shape.go

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -622,25 +622,13 @@ var structShapeTmpl = func() *template.Template {
622622

623623
const structShapeTmplDef = `
624624
{{ .Docstring }}
625-
{{ if ne $.OrigShapeName "" -}}
626-
{{ $crosslinkURL := GetCrosslinkURL $.API.BaseCrosslinkURL $.API.Metadata.UID $.OrigShapeName -}}
627-
{{ if ne $crosslinkURL "" -}}
628-
// Please also see {{ $crosslinkURL }}
629-
{{ end -}}
630-
{{ else -}}
631-
{{ $crosslinkURL := GetCrosslinkURL $.API.BaseCrosslinkURL $.API.Metadata.UID $.ShapeName -}}
632-
{{ if ne $crosslinkURL "" -}}
633-
// Please also see {{ $crosslinkURL }}
634-
{{ end -}}
635-
{{ end -}}
636-
{{ $context := . -}}
637625
type {{ .ShapeName }} struct {
638626
_ struct{} {{ .GoTags true false }}
639627
640-
{{ range $_, $name := $context.MemberNames -}}
641-
{{ $elem := index $context.MemberRefs $name -}}
642-
{{ $isBlob := $context.WillRefBeBase64Encoded $name -}}
643-
{{ $isRequired := $context.IsRequired $name -}}
628+
{{ range $_, $name := $.MemberNames -}}
629+
{{ $elem := index $.MemberRefs $name -}}
630+
{{ $isBlob := $.WillRefBeBase64Encoded $name -}}
631+
{{ $isRequired := $.IsRequired $name -}}
644632
{{ $doc := $elem.Docstring -}}
645633
646634
{{ if $doc -}}
@@ -658,7 +646,7 @@ type {{ .ShapeName }} struct {
658646
{{ end -}}
659647
// {{ $name }} is a required field
660648
{{ end -}}
661-
{{ $name }} {{ $context.GoStructType $name $elem }} {{ $elem.GoTags false $isRequired }}
649+
{{ $name }} {{ $.GoStructType $name $elem }} {{ $elem.GoTags false $isRequired }}
662650
663651
{{ end }}
664652
}
@@ -675,11 +663,11 @@ type {{ .ShapeName }} struct {
675663
676664
{{ $builderShapeName := print .ShapeName -}}
677665
678-
{{ range $_, $name := $context.MemberNames -}}
679-
{{ $elem := index $context.MemberRefs $name -}}
666+
{{ range $_, $name := $.MemberNames -}}
667+
{{ $elem := index $.MemberRefs $name -}}
680668
681669
{{ if $elem.GenerateGetter -}}
682-
func (s *{{ $builderShapeName }}) get{{ $name }}() (v {{ $context.GoStructValueType $name $elem }}) {
670+
func (s *{{ $builderShapeName }}) get{{ $name }}() (v {{ $.GoStructValueType $name $elem }}) {
683671
{{ if $elem.UseIndirection -}}
684672
if s.{{ $name }} == nil {
685673
return v
@@ -714,9 +702,8 @@ type {{ $.EnumType }} string
714702
715703
// Enum values for {{ $.EnumType }}
716704
const (
717-
{{ $context := . -}}
718705
{{ range $index, $elem := .Enum -}}
719-
{{ $name := index $context.EnumConsts $index -}}
706+
{{ $name := index $.EnumConsts $index -}}
720707
{{ $name }} {{ $.EnumType }} = "{{ $elem }}"
721708
{{ end -}}
722709
)

service/acm/api_op_AddTagsToCertificate.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/acm/api_op_DeleteCertificate.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/acm/api_op_DescribeCertificate.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/acm/api_op_ExportCertificate.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/acm/api_op_GetCertificate.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/acm/api_op_ImportCertificate.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/acm/api_op_ListCertificates.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/acm/api_op_ListTagsForCertificate.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)