aws/signer/v2: Use constant instead of string literal for POST/GET (#635)

heartwilltell · web-flow · commit c1ad81608c5c · 2020-07-14T14:20:36.000-07:00
Updates the v2 signer to use predefined constants instead of string literals for POST and GET HTTP methods.
diff --git a/aws/signer/v2/v2.go b/aws/signer/v2/v2.go
@@ -57,7 +57,7 @@ func SignSDKRequest(req *aws.Request) {
 		return
 	}
 
-	if req.HTTPRequest.Method != "POST" && req.HTTPRequest.Method != "GET" {
+	if req.HTTPRequest.Method != http.MethodPost && req.HTTPRequest.Method != http.MethodGet {
 		// The V2 signer only supports GET and POST
 		req.Error = errInvalidMethod
 		return

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ func SignSDKRequest(req *aws.Request) {`
`57`	`57`	`return`
`58`	`58`	`}`
`59`	`59`
`60`		`- if req.HTTPRequest.Method != "POST" && req.HTTPRequest.Method != "GET" {`
	`60`	`+ if req.HTTPRequest.Method != http.MethodPost && req.HTTPRequest.Method != http.MethodGet {`
`61`	`61`	`// The V2 signer only supports GET and POST`
`62`	`62`	`req.Error = errInvalidMethod`
`63`	`63`	`return`