Skip to content

Commit c5c319f

Browse files
authored
breakfix nil VpcOptions (#3160)
1 parent 789d602 commit c5c319f

File tree

5 files changed

+31
-17
lines changed

5 files changed

+31
-17
lines changed
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"id": "84297171-0ea1-4a5a-ad4a-dd0ee0ffef23",
3+
"type": "bugfix",
4+
"description": "**BREAKING CHANGE**: The fields on VpcOptions have been changed from `bool` to `*bool`. Before this change, the fields were incorrectly marked as having default values of false by the service, which made it functionally impossible for users to set them false in an API call.",
5+
"modules": [
6+
"service/networkmanager"
7+
]
8+
}

codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/RemoveDefaults.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,13 @@ public class RemoveDefaults implements GoIntegration {
4040
serviceToShapeIds("com.amazonaws.dataexchange#DataExchange",
4141
// https://github.com/aws/aws-sdk-go-v2/issues/3066
4242
// we need to target synthetic shapes since we generate synthetic input shapes
43-
"smithy.go.synthetic#UpdateRevisionInput$Finalized")
43+
"smithy.go.synthetic#UpdateRevisionInput$Finalized"),
44+
serviceToShapeIds("com.amazonaws.networkmanager#NetworkManager",
45+
// https://github.com/aws/aws-sdk-go-v2/issues/3158
46+
"com.amazonaws.networkmanager#VpcOptions$Ipv6Support",
47+
"com.amazonaws.networkmanager#VpcOptions$ApplianceModeSupport",
48+
"com.amazonaws.networkmanager#VpcOptions$DnsSupport",
49+
"com.amazonaws.networkmanager#VpcOptions$SecurityGroupReferencingSupport")
4450
);
4551

4652
private boolean mustPreprocess(ShapeId service) {

service/networkmanager/deserializers.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/networkmanager/serializers.go

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/networkmanager/types/types.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)