Skip to content

Commit 036d0e3

Browse files
authored
Remove leftover TODOs (#3514)
1 parent fbc6461 commit 036d0e3

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

codegen/src/main/java/software/amazon/awssdk/codegen/poet/rules/EndpointResolverInterceptorSpec.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ private MethodSpec ruleParams() {
173173
case AWS_S3_CONTROL_USE_ARN_REGION:
174174
// end of S3 specific builtins
175175
case AWS_STS_USE_GLOBAL_ENDPOINT:
176-
// TODO: handle this
176+
// V2 doesn't support this, only regional endpoints
177177
return;
178178
default:
179179
throw new RuntimeException("Don't know how to set built-in " + m.getBuiltInEnum());

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/endpoints/UseGlobalEndpointResolver.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,15 @@
2424
import software.amazon.awssdk.profiles.ProfileProperty;
2525
import software.amazon.awssdk.regions.Region;
2626
import software.amazon.awssdk.regions.ServiceMetadataAdvancedOption;
27+
import software.amazon.awssdk.regions.servicemetadata.EnhancedS3ServiceMetadata;
2728
import software.amazon.awssdk.utils.Lazy;
2829
import software.amazon.awssdk.utils.Logger;
2930

3031
/**
31-
* Note: Most of the logic is copied from EnhancedS3ServiceMetadata
32-
* // TODO: should probably refactor that class to reuse the same logic
32+
* Resolve the use global endpoint setting for S3.
33+
* <p>
34+
* This logic is identical to that in {@link EnhancedS3ServiceMetadata}, there's no good way to share it aside from creating a
35+
* protected API that both the s3 and regions module consume.
3336
*/
3437
@SdkInternalApi
3538
public class UseGlobalEndpointResolver {

0 commit comments

Comments
 (0)