Skip to content

Commit 0452595

Browse files
committed
Add changelog + fix checkstyle
1 parent 397dad6 commit 0452595

File tree

6 files changed

+12
-16
lines changed

6 files changed

+12
-16
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"type": "bugfix",
3+
"category": "AWS Query Protocol",
4+
"contributor": "",
5+
"description": "Preserve the path set on a custom endpoint configured on the client."
6+
}

test/protocol-tests-core/src/main/java/software/amazon/awssdk/protocol/asserts/marshalling/QueryBodyAssertion.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ private void assertParamsEqual(List<String> actual, List<String> expected) {
6464
}
6565

6666
public static boolean isNumeric(String str) {
67-
if (str == null || str.isEmpty()) return false;
67+
if (str == null || str.isEmpty()) {
68+
return false;
69+
}
6870
try {
6971
Double.parseDouble(str);
7072
return true;

test/protocol-tests-core/src/main/java/software/amazon/awssdk/protocol/asserts/marshalling/QueryParamsAssertion.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,8 @@
2424
import static software.amazon.awssdk.protocol.asserts.marshalling.QueryUtils.parseQueryParamsFromBody;
2525

2626
import com.github.tomakehurst.wiremock.verification.LoggedRequest;
27-
import java.net.URI;
28-
import java.nio.charset.StandardCharsets;
29-
import java.util.Collections;
3027
import java.util.List;
3128
import java.util.Map;
32-
import java.util.stream.Collectors;
33-
import org.apache.http.NameValuePair;
34-
import org.apache.http.client.utils.URLEncodedUtils;
35-
import software.amazon.awssdk.utils.StringUtils;
3629

3730
/**
3831
* Asserts on the query parameters of the marshalled request.

test/protocol-tests-core/src/main/java/software/amazon/awssdk/protocol/asserts/marshalling/QueryUtils.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
import software.amazon.awssdk.utils.StringUtils;
2828

2929
public final class QueryUtils {
30-
private QueryUtils() {}
30+
private QueryUtils() {
31+
}
3132

3233
public static Map<String, List<String>> parseQueryParamsFromBody(String body) {
3334
return toQueryParamMap(URLEncodedUtils.parse(body, StandardCharsets.UTF_8));

test/protocol-tests-core/src/main/java/software/amazon/awssdk/protocol/asserts/marshalling/ResolvedHostAssertion.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ public ResolvedHostAssertion(String host) {
3131

3232
@Override
3333
protected void doAssert(LoggedRequest actual) throws Exception {
34-
// TODO:
35-
// assertEquals(removeTrailingSlash(expectedUri), removeTrailingSlash(getActualPath(actual)));
34+
assertEquals(expectedHost, actual.getHost());
3635
}
37-
3836
}

test/protocol-tests-core/src/main/java/software/amazon/awssdk/protocol/runners/MarshallingTestRunner.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,7 @@
2626
import com.github.tomakehurst.wiremock.client.ResponseDefinitionBuilder;
2727
import com.github.tomakehurst.wiremock.client.WireMock;
2828
import com.github.tomakehurst.wiremock.verification.LoggedRequest;
29-
import java.lang.reflect.InvocationTargetException;
30-
import java.net.URI;
3129
import java.util.List;
32-
import org.junit.Assert;
3330
import software.amazon.awssdk.awscore.AwsRequest;
3431
import software.amazon.awssdk.codegen.model.intermediate.IntermediateModel;
3532
import software.amazon.awssdk.core.interceptor.Context;
@@ -41,7 +38,6 @@
4138
import software.amazon.awssdk.protocol.reflect.ClientReflector;
4239
import software.amazon.awssdk.protocol.reflect.ShapeModelReflector;
4340
import software.amazon.awssdk.protocol.wiremock.WireMockUtils;
44-
import software.amazon.awssdk.utils.StringUtils;
4541

4642
/**
4743
* Test runner for test cases exercising the client marshallers.

0 commit comments

Comments
 (0)