PR feedback

Author: S-Saranya1

core/aws-core/src/main/java/software/amazon/awssdk/awscore/internal/AwsExecutionContextBuilder.java

@@ -16,6 +16,7 @@
 package software.amazon.awssdk.awscore.internal;
 
 import static software.amazon.awssdk.auth.signer.internal.util.SignerMethodResolver.resolveSigningMethodUsed;
+import static software.amazon.awssdk.awscore.internal.AwsServiceProtocol.SMITHY_RPC_V2_CBOR;
 import static software.amazon.awssdk.core.client.config.SdkClientOption.RETRY_POLICY;
 import static software.amazon.awssdk.core.client.config.SdkClientOption.RETRY_STRATEGY;
 import static software.amazon.awssdk.core.interceptor.SdkExecutionAttribute.RESOLVED_CHECKSUM_SPECS;
@@ -370,6 +371,6 @@ private static EndpointProvider resolveEndpointProvider(SdkRequest request,
 
     private static boolean isRpcV2CborProtocol(SdkProtocolMetadata protocolMetadata) {
         return protocolMetadata != null &&
-               "smithy-rpc-v2-cbor".equals(protocolMetadata.serviceProtocol());
+               SMITHY_RPC_V2_CBOR.toString().equals(protocolMetadata.serviceProtocol());
     }
 }

test/codegen-generated-classes-test/pom.xml

@@ -145,6 +145,11 @@
             <artifactId>retries-spi</artifactId>
             <version>${awsjavasdk.version}</version>
         </dependency>
+        <dependency>
+            <groupId>software.amazon.awssdk</groupId>
+            <artifactId>smithy-rpcv2-protocol</artifactId>
+            <version>${awsjavasdk.version}</version>
+        </dependency>
         <dependency>
             <artifactId>netty-nio-client</artifactId>
             <groupId>software.amazon.awssdk</groupId>
@@ -279,12 +284,6 @@
             <artifactId>mockito-junit-jupiter</artifactId>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>software.amazon.awssdk</groupId>
-            <artifactId>smithy-rpcv2-protocol</artifactId>
-            <version>${awsjavasdk.version}</version>
-            <scope>compile</scope>
-        </dependency>
     </dependencies>
 
     <build>