Update exception thrown to SdkClientException, fix tests

Author: alextwoods

core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/async/FileAsyncRequestBody.java

@@ -36,6 +36,7 @@
 import software.amazon.awssdk.core.async.AsyncRequestBodySplitConfiguration;
 import software.amazon.awssdk.core.async.CloseableAsyncRequestBody;
 import software.amazon.awssdk.core.async.SdkPublisher;
+import software.amazon.awssdk.core.exception.SdkClientException;
 import software.amazon.awssdk.core.internal.util.Mimetype;
 import software.amazon.awssdk.core.internal.util.NoopSubscription;
 import software.amazon.awssdk.utils.Logger;
@@ -469,31 +470,30 @@ private boolean validateFileUnchanged() {
             try {
                 long sizeAtEnd = Files.size(path);
                 if (sizeAtStart != sizeAtEnd) {
-                    signalOnError(new RuntimeException("File size changed after reading started. Initial size: "
-                                                       + sizeAtStart + ". Current size: " + sizeAtEnd));
+                    signalOnError(SdkClientException.create("File size changed after reading started. Initial size: "
+                                                         + sizeAtStart + ". Current size: " + sizeAtEnd));
                     return false;
                 }
 
                 if (remainingBytes.get() > 0) {
-                    signalOnError(new RuntimeException("Fewer bytes were read than were expected, was the file modified after "
-                                                  + "reading started?"));
+                    signalOnError(SdkClientException.create("Fewer bytes were read than were expected, was the file modified "
+                                                           + "after reading started?"));
                     return false;
                 }
 
                 FileTime modifiedTimeAtEnd = Files.getLastModifiedTime(path);
                 if (modifiedTimeAtStart.compareTo(modifiedTimeAtEnd) != 0) {
-                    signalOnError(
-                        new RuntimeException("File last-modified time changed after reading started. Initial modification "
-                                             + "time: " + modifiedTimeAtStart + ". Current modification time: " +
-                                             modifiedTimeAtEnd));
+                    signalOnError(SdkClientException.create("File last-modified time changed after reading started. "
+                                                            + "Initial modification time: " + modifiedTimeAtStart
+                                                            + ". Current modification time: " + modifiedTimeAtEnd));
                     return false;
                 }
             } catch (NoSuchFileException e) {
-                signalOnError(new IOException("Unable to check file status after read. Was the file deleted or were its "
-                                              + "permissions changed?", e));
+                signalOnError(SdkClientException.create("Unable to check file status after read. Was the file deleted"
+                                                        + " or were its permissions changed?", e));
                 return false;
             } catch (IOException e) {
-                signalOnError(new IOException("Unable to check file status after read.", e));
+                signalOnError(SdkClientException.create("Unable to check file status after read.", e));
                 return false;
             }
             return true;

core/sdk-core/src/test/java/software/amazon/awssdk/core/internal/async/FileAsyncRequestBodyTest.java

@@ -40,6 +40,7 @@
 import org.reactivestreams.Subscriber;
 import org.reactivestreams.Subscription;
 import software.amazon.awssdk.core.async.AsyncRequestBody;
+import software.amazon.awssdk.core.exception.SdkClientException;
 import software.amazon.awssdk.testutils.RandomTempFile;
 import software.amazon.awssdk.utils.BinaryUtils;
 
@@ -128,7 +129,7 @@ public void changingFile_fileGetsShorterThanAlreadyRead_failsBecauseTooShort() t
         subscriber.sub.request(Long.MAX_VALUE);
 
         assertThatThrownBy(() -> subscriber.completed.get(5, TimeUnit.SECONDS))
-            .hasCauseInstanceOf(IOException.class);
+            .hasCauseInstanceOf(SdkClientException.class);
     }
 
     @Test
@@ -154,7 +155,7 @@ public void changingFile_fileGetsShorterThanExistingLength_failsBecauseTooShort(
         subscriber.sub.request(Long.MAX_VALUE);
 
         assertThatThrownBy(() -> subscriber.completed.get(5, TimeUnit.SECONDS))
-            .hasCauseInstanceOf(IOException.class);
+            .hasCauseInstanceOf(SdkClientException.class);
     }
 
     @Test
@@ -180,7 +181,7 @@ public void changingFile_fileGetsLongerThanExistingLength_failsBecauseTooLong()
         subscriber.sub.request(Long.MAX_VALUE);
 
         assertThatThrownBy(() -> subscriber.completed.get(5, TimeUnit.SECONDS))
-            .hasCauseInstanceOf(IOException.class);
+            .hasCauseInstanceOf(SdkClientException.class);
     }
 
     @Test
@@ -204,7 +205,7 @@ public void changingFile_fileGetsTouched_failsBecauseUpdatedModificationTime() t
         subscriber.sub.request(Long.MAX_VALUE);
 
         assertThatThrownBy(() -> subscriber.completed.get(5, TimeUnit.SECONDS))
-            .hasCauseInstanceOf(IOException.class);
+            .hasCauseInstanceOf(SdkClientException.class);
     }
 
     @Test
@@ -227,7 +228,7 @@ public void changingFile_fileGetsDeleted_failsBecauseDeleted() throws Exception
         subscriber.sub.request(Long.MAX_VALUE);
 
         assertThatThrownBy(() -> subscriber.completed.get(5, TimeUnit.SECONDS))
-            .hasCauseInstanceOf(IOException.class);
+            .hasCauseInstanceOf(SdkClientException.class);
     }
 
     @Test