Skip to content

Commit 24843b1

Browse files
committed
Address feedback
1 parent 20fefac commit 24843b1

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

core/sdk-core/src/main/java/software/amazon/awssdk/core/SdkPlugin.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,10 @@
104104
* <li>Global SDK defaults</li>
105105
* </ol>
106106
*
107+
* <p><b>Note:</b> Request-level plugins have different precedence behavior. Request-level override configuration
108+
* takes precedence over request-level plugin settings, meaning direct request configuration will override plugin
109+
* settings for that request.
110+
*
107111
* @see software.amazon.awssdk.core.client.builder.SdkClientBuilder#addPlugin(SdkPlugin)
108112
* @see software.amazon.awssdk.core.RequestOverrideConfiguration.Builder#addPlugin(SdkPlugin)
109113
*/

test/codegen-generated-classes-test/src/test/java/software/amazon/awssdk/services/AsyncRequestBodyFlexibleChecksumInTrailerTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@
2626
import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo;
2727
import static com.github.tomakehurst.wiremock.client.WireMock.verify;
2828
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
29-
import static software.amazon.awssdk.auth.signer.S3SignerExecutionAttribute.ENABLE_CHUNKED_ENCODING;
30-
import static software.amazon.awssdk.auth.signer.S3SignerExecutionAttribute.ENABLE_PAYLOAD_SIGNING;
3129
import static software.amazon.awssdk.http.Header.CONTENT_LENGTH;
3230
import static software.amazon.awssdk.http.Header.CONTENT_TYPE;
3331

test/codegen-generated-classes-test/src/test/java/software/amazon/awssdk/services/SdkPluginTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import java.util.function.BiConsumer;
3939
import java.util.function.Supplier;
4040
import java.util.stream.Stream;
41-
import org.junit.jupiter.api.Disabled;
4241
import org.junit.jupiter.params.ParameterizedTest;
4342
import org.junit.jupiter.params.provider.MethodSource;
4443
import org.mockito.Mockito;
@@ -61,8 +60,6 @@
6160
import software.amazon.awssdk.core.interceptor.ExecutionInterceptor;
6261
import software.amazon.awssdk.core.interceptor.SdkInternalExecutionAttribute;
6362
import software.amazon.awssdk.core.internal.retry.SdkDefaultRetryStrategy;
64-
import software.amazon.awssdk.core.retry.RetryMode;
65-
import software.amazon.awssdk.core.retry.RetryPolicy;
6663
import software.amazon.awssdk.endpoints.Endpoint;
6764
import software.amazon.awssdk.http.SdkHttpClient;
6865
import software.amazon.awssdk.http.auth.aws.scheme.AwsV4AuthScheme;
@@ -77,7 +74,6 @@
7774
import software.amazon.awssdk.profiles.ProfileFile;
7875
import software.amazon.awssdk.profiles.ProfileProperty;
7976
import software.amazon.awssdk.regions.Region;
80-
import software.amazon.awssdk.retries.DefaultRetryStrategy;
8177
import software.amazon.awssdk.retries.api.RetryStrategy;
8278
import software.amazon.awssdk.services.protocolrestjson.ProtocolRestJsonClient;
8379
import software.amazon.awssdk.services.protocolrestjson.ProtocolRestJsonClientBuilder;

0 commit comments

Comments
 (0)