Skip to content

Commit 2be8d80

Browse files
committed
Add changelog + fix warning usage
1 parent 50e38ca commit 2be8d80

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"type": "feature",
3+
"category": "AWS S3",
4+
"contributor": "",
5+
"description": "Add support for using CRT's response file in the CRT based S3AsyncClient - CRT will directly write to the file when calling getObject with a Path."
6+
}

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/CrtResponseFileResponseTransformer.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ public void exceptionOccurred(Throwable throwable) {
6464
} else {
6565
log.warn(() -> "An exception occurred before the call to prepare() was able to instantiate the CompletableFuture."
6666
+ "The future cannot be completed exceptionally because it is null");
67-
6867
}
6968
}
7069

test/architecture-tests/src/test/java/software/amazon/awssdk/archtests/CodingConventionWithSuppressionTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,9 @@ public class CodingConventionWithSuppressionTest {
5050
Arrays.asList(ArchUtils.classNameToPattern(EmfMetricLoggingPublisher.class),
5151
ArchUtils.classNameToPattern(MetricEmfConverter.class),
5252
ArchUtils.classNameToPattern(MakeHttpRequestStage.class),
53-
ArchUtils.classNameToPattern("software.amazon.awssdk.services.s3.internal.crt.S3CrtResponseHandlerAdapter")));
53+
ArchUtils.classNameToPattern("software.amazon.awssdk.services.s3.internal.crt.S3CrtResponseHandlerAdapter"),
54+
ArchUtils.classNameToPattern(
55+
"software.amazon.awssdk.services.s3.internal.crt.CrtResponseFileResponseTransformer")));
5456

5557
private static final Set<Pattern> ALLOWED_ERROR_LOG_SUPPRESSION = new HashSet<>(
5658
Arrays.asList(

0 commit comments

Comments
 (0)