Skip to content

Commit 2e4452a

Browse files
author
AWS
committed
Payment Cryptography Data Plane Update: Make KeyCheckValue field optional when using asymmetric keys as Key Check Values typically only apply to symmetric keys
1 parent 737af3a commit 2e4452a

File tree

3 files changed

+103
-64
lines changed

3 files changed

+103
-64
lines changed

‎.changes/next-release/feature-PaymentCryptographyDataPlane-303799e.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"type": "feature",
3+
"category": "Payment Cryptography Data Plane",
4+
"contributor": "",
5+
"description": "Make KeyCheckValue field optional when using asymmetric keys as Key Check Values typically only apply to symmetric keys"
6+
}

‎services/paymentcryptographydata/src/main/resources/codegen-resources/endpoint-tests.json

Lines changed: 71 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,54 @@
11
{
22
"testCases": [
33
{
4-
"documentation": "For region us-gov-east-1 with FIPS enabled and DualStack enabled",
4+
"documentation": "For region us-east-1 with FIPS enabled and DualStack enabled",
55
"expect": {
66
"endpoint": {
7-
"url": "https://dataplane.payment-cryptography-fips.us-gov-east-1.api.aws"
7+
"url": "https://dataplane.payment-cryptography-fips.us-east-1.api.aws"
88
}
99
},
1010
"params": {
11+
"Region": "us-east-1",
1112
"UseFIPS": true,
12-
"Region": "us-gov-east-1",
1313
"UseDualStack": true
1414
}
1515
},
1616
{
17-
"documentation": "For region us-gov-east-1 with FIPS enabled and DualStack disabled",
17+
"documentation": "For region us-east-1 with FIPS enabled and DualStack disabled",
1818
"expect": {
1919
"endpoint": {
20-
"url": "https://dataplane.payment-cryptography-fips.us-gov-east-1.amazonaws.com"
20+
"url": "https://dataplane.payment-cryptography-fips.us-east-1.amazonaws.com"
2121
}
2222
},
2323
"params": {
24+
"Region": "us-east-1",
2425
"UseFIPS": true,
25-
"Region": "us-gov-east-1",
2626
"UseDualStack": false
2727
}
2828
},
2929
{
30-
"documentation": "For region us-gov-east-1 with FIPS disabled and DualStack enabled",
30+
"documentation": "For region us-east-1 with FIPS disabled and DualStack enabled",
3131
"expect": {
3232
"endpoint": {
33-
"url": "https://dataplane.payment-cryptography.us-gov-east-1.api.aws"
33+
"url": "https://dataplane.payment-cryptography.us-east-1.api.aws"
3434
}
3535
},
3636
"params": {
37+
"Region": "us-east-1",
3738
"UseFIPS": false,
38-
"Region": "us-gov-east-1",
3939
"UseDualStack": true
4040
}
4141
},
4242
{
43-
"documentation": "For region us-gov-east-1 with FIPS disabled and DualStack disabled",
43+
"documentation": "For region us-east-1 with FIPS disabled and DualStack disabled",
4444
"expect": {
4545
"endpoint": {
46-
"url": "https://dataplane.payment-cryptography.us-gov-east-1.amazonaws.com"
46+
"url": "https://dataplane.payment-cryptography.us-east-1.amazonaws.com"
4747
}
4848
},
4949
"params": {
50+
"Region": "us-east-1",
5051
"UseFIPS": false,
51-
"Region": "us-gov-east-1",
5252
"UseDualStack": false
5353
}
5454
},
@@ -60,8 +60,8 @@
6060
}
6161
},
6262
"params": {
63-
"UseFIPS": true,
6463
"Region": "cn-north-1",
64+
"UseFIPS": true,
6565
"UseDualStack": true
6666
}
6767
},
@@ -73,8 +73,8 @@
7373
}
7474
},
7575
"params": {
76-
"UseFIPS": true,
7776
"Region": "cn-north-1",
77+
"UseFIPS": true,
7878
"UseDualStack": false
7979
}
8080
},
@@ -86,8 +86,8 @@
8686
}
8787
},
8888
"params": {
89-
"UseFIPS": false,
9089
"Region": "cn-north-1",
90+
"UseFIPS": false,
9191
"UseDualStack": true
9292
}
9393
},
@@ -99,108 +99,108 @@
9999
}
100100
},
101101
"params": {
102-
"UseFIPS": false,
103102
"Region": "cn-north-1",
103+
"UseFIPS": false,
104104
"UseDualStack": false
105105
}
106106
},
107107
{
108-
"documentation": "For region us-iso-east-1 with FIPS enabled and DualStack enabled",
108+
"documentation": "For region us-gov-east-1 with FIPS enabled and DualStack enabled",
109109
"expect": {
110-
"error": "FIPS and DualStack are enabled, but this partition does not support one or both"
110+
"endpoint": {
111+
"url": "https://dataplane.payment-cryptography-fips.us-gov-east-1.api.aws"
112+
}
111113
},
112114
"params": {
115+
"Region": "us-gov-east-1",
113116
"UseFIPS": true,
114-
"Region": "us-iso-east-1",
115117
"UseDualStack": true
116118
}
117119
},
118120
{
119-
"documentation": "For region us-iso-east-1 with FIPS enabled and DualStack disabled",
121+
"documentation": "For region us-gov-east-1 with FIPS enabled and DualStack disabled",
120122
"expect": {
121123
"endpoint": {
122-
"url": "https://dataplane.payment-cryptography-fips.us-iso-east-1.c2s.ic.gov"
124+
"url": "https://dataplane.payment-cryptography-fips.us-gov-east-1.amazonaws.com"
123125
}
124126
},
125127
"params": {
128+
"Region": "us-gov-east-1",
126129
"UseFIPS": true,
127-
"Region": "us-iso-east-1",
128130
"UseDualStack": false
129131
}
130132
},
131133
{
132-
"documentation": "For region us-iso-east-1 with FIPS disabled and DualStack enabled",
134+
"documentation": "For region us-gov-east-1 with FIPS disabled and DualStack enabled",
133135
"expect": {
134-
"error": "DualStack is enabled but this partition does not support DualStack"
136+
"endpoint": {
137+
"url": "https://dataplane.payment-cryptography.us-gov-east-1.api.aws"
138+
}
135139
},
136140
"params": {
141+
"Region": "us-gov-east-1",
137142
"UseFIPS": false,
138-
"Region": "us-iso-east-1",
139143
"UseDualStack": true
140144
}
141145
},
142146
{
143-
"documentation": "For region us-iso-east-1 with FIPS disabled and DualStack disabled",
147+
"documentation": "For region us-gov-east-1 with FIPS disabled and DualStack disabled",
144148
"expect": {
145149
"endpoint": {
146-
"url": "https://dataplane.payment-cryptography.us-iso-east-1.c2s.ic.gov"
150+
"url": "https://dataplane.payment-cryptography.us-gov-east-1.amazonaws.com"
147151
}
148152
},
149153
"params": {
154+
"Region": "us-gov-east-1",
150155
"UseFIPS": false,
151-
"Region": "us-iso-east-1",
152156
"UseDualStack": false
153157
}
154158
},
155159
{
156-
"documentation": "For region us-east-1 with FIPS enabled and DualStack enabled",
160+
"documentation": "For region us-iso-east-1 with FIPS enabled and DualStack enabled",
157161
"expect": {
158-
"endpoint": {
159-
"url": "https://dataplane.payment-cryptography-fips.us-east-1.api.aws"
160-
}
162+
"error": "FIPS and DualStack are enabled, but this partition does not support one or both"
161163
},
162164
"params": {
165+
"Region": "us-iso-east-1",
163166
"UseFIPS": true,
164-
"Region": "us-east-1",
165167
"UseDualStack": true
166168
}
167169
},
168170
{
169-
"documentation": "For region us-east-1 with FIPS enabled and DualStack disabled",
171+
"documentation": "For region us-iso-east-1 with FIPS enabled and DualStack disabled",
170172
"expect": {
171173
"endpoint": {
172-
"url": "https://dataplane.payment-cryptography-fips.us-east-1.amazonaws.com"
174+
"url": "https://dataplane.payment-cryptography-fips.us-iso-east-1.c2s.ic.gov"
173175
}
174176
},
175177
"params": {
178+
"Region": "us-iso-east-1",
176179
"UseFIPS": true,
177-
"Region": "us-east-1",
178180
"UseDualStack": false
179181
}
180182
},
181183
{
182-
"documentation": "For region us-east-1 with FIPS disabled and DualStack enabled",
184+
"documentation": "For region us-iso-east-1 with FIPS disabled and DualStack enabled",
183185
"expect": {
184-
"endpoint": {
185-
"url": "https://dataplane.payment-cryptography.us-east-1.api.aws"
186-
}
186+
"error": "DualStack is enabled but this partition does not support DualStack"
187187
},
188188
"params": {
189+
"Region": "us-iso-east-1",
189190
"UseFIPS": false,
190-
"Region": "us-east-1",
191191
"UseDualStack": true
192192
}
193193
},
194194
{
195-
"documentation": "For region us-east-1 with FIPS disabled and DualStack disabled",
195+
"documentation": "For region us-iso-east-1 with FIPS disabled and DualStack disabled",
196196
"expect": {
197197
"endpoint": {
198-
"url": "https://dataplane.payment-cryptography.us-east-1.amazonaws.com"
198+
"url": "https://dataplane.payment-cryptography.us-iso-east-1.c2s.ic.gov"
199199
}
200200
},
201201
"params": {
202+
"Region": "us-iso-east-1",
202203
"UseFIPS": false,
203-
"Region": "us-east-1",
204204
"UseDualStack": false
205205
}
206206
},
@@ -210,8 +210,8 @@
210210
"error": "FIPS and DualStack are enabled, but this partition does not support one or both"
211211
},
212212
"params": {
213-
"UseFIPS": true,
214213
"Region": "us-isob-east-1",
214+
"UseFIPS": true,
215215
"UseDualStack": true
216216
}
217217
},
@@ -223,8 +223,8 @@
223223
}
224224
},
225225
"params": {
226-
"UseFIPS": true,
227226
"Region": "us-isob-east-1",
227+
"UseFIPS": true,
228228
"UseDualStack": false
229229
}
230230
},
@@ -234,8 +234,8 @@
234234
"error": "DualStack is enabled but this partition does not support DualStack"
235235
},
236236
"params": {
237-
"UseFIPS": false,
238237
"Region": "us-isob-east-1",
238+
"UseFIPS": false,
239239
"UseDualStack": true
240240
}
241241
},
@@ -247,21 +247,34 @@
247247
}
248248
},
249249
"params": {
250-
"UseFIPS": false,
251250
"Region": "us-isob-east-1",
251+
"UseFIPS": false,
252252
"UseDualStack": false
253253
}
254254
},
255255
{
256-
"documentation": "For custom endpoint with fips disabled and dualstack disabled",
256+
"documentation": "For custom endpoint with region set and fips disabled and dualstack disabled",
257257
"expect": {
258258
"endpoint": {
259259
"url": "https://example.com"
260260
}
261261
},
262262
"params": {
263-
"UseFIPS": false,
264263
"Region": "us-east-1",
264+
"UseFIPS": false,
265+
"UseDualStack": false,
266+
"Endpoint": "https://example.com"
267+
}
268+
},
269+
{
270+
"documentation": "For custom endpoint with region not set and fips disabled and dualstack disabled",
271+
"expect": {
272+
"endpoint": {
273+
"url": "https://example.com"
274+
}
275+
},
276+
"params": {
277+
"UseFIPS": false,
265278
"UseDualStack": false,
266279
"Endpoint": "https://example.com"
267280
}
@@ -272,8 +285,8 @@
272285
"error": "Invalid Configuration: FIPS and custom endpoint are not supported"
273286
},
274287
"params": {
275-
"UseFIPS": true,
276288
"Region": "us-east-1",
289+
"UseFIPS": true,
277290
"UseDualStack": false,
278291
"Endpoint": "https://example.com"
279292
}
@@ -284,11 +297,17 @@
284297
"error": "Invalid Configuration: Dualstack and custom endpoint are not supported"
285298
},
286299
"params": {
287-
"UseFIPS": false,
288300
"Region": "us-east-1",
301+
"UseFIPS": false,
289302
"UseDualStack": true,
290303
"Endpoint": "https://example.com"
291304
}
305+
},
306+
{
307+
"documentation": "Missing region",
308+
"expect": {
309+
"error": "Invalid Configuration: Missing Region"
310+
}
292311
}
293312
],
294313
"version": "1.0"

0 commit comments

Comments
 (0)