Skip to content

Commit 4b697d1

Browse files
committed
Address PR feedback
1 parent 61f41e3 commit 4b697d1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docs/guidelines/business-metrics-guidelines.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Business metrics are short identifiers added to the User-Agent header for teleme
2020

2121
### Feature-Centric Placement
2222

23-
**MUST** add business metrics where the feature is resolved, at the point where it is finalized that the feature is being used. Consider cases where features can be overridden - the decision is to add business metrics at the place where the feature is finalized.
23+
**MUST** add business metrics when we finalize/know for sure that the feature is being used. To account for cases where features can be overridden, add business metrics at the point where feature usage is confirmed and finalized.
2424

2525
**Rationale:** Based on team discussion, this approach was chosen over centralized placement in `ApplyUserAgentStage` because:
2626
- **Better separation of concerns**: `ApplyUserAgentStage` remains ignorant of internal feature implementation details

0 commit comments

Comments
 (0)