Skip to content

Commit 5546860

Browse files
authored
Update ReceiveBatchesMockTest to remove delayed response parameter when mock SQS responses are expected ASAP (#5594)
1 parent 1b46134 commit 5546860

File tree

1 file changed

+19
-7
lines changed

1 file changed

+19
-7
lines changed

services/sqs/src/test/java/software/amazon/awssdk/services/sqs/batchmanager/ReceiveBatchesMockTest.java

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,9 @@ void testTimeoutOccursBeforeSqsResponds() throws Exception {
8787
void testResponseReceivedBeforeTimeout() throws Exception {
8888
setupBatchManager();
8989

90-
// Delays for testing
91-
int queueAttributesApiDelay = 5;
92-
int receiveMessagesDelay = 5;
93-
94-
// Set short delays to ensure response before timeout
95-
mockQueueAttributes(queueAttributesApiDelay);
96-
mockReceiveMessages(receiveMessagesDelay, 2);
90+
// No delays set since we mock quick response from SQS.
91+
mockQueueAttributes();
92+
mockReceiveMessages(2);
9793

9894
CompletableFuture<ReceiveMessageResponse> future = batchManagerReceiveMessage();
9995
assertThat(future.get(5, TimeUnit.SECONDS).messages()).hasSize(2);
@@ -179,6 +175,22 @@ private void mockReceiveMessages(int delay, int numMessages) {
179175
.withFixedDelay(delay)));
180176
}
181177

178+
private void mockReceiveMessages(int numMessages) {
179+
stubFor(post(urlEqualTo("/"))
180+
.withHeader("x-amz-target", equalTo("AmazonSQS.ReceiveMessage"))
181+
.willReturn(aResponse()
182+
.withStatus(200)
183+
.withBody(generateMessagesJson(numMessages))));
184+
}
185+
186+
private void mockQueueAttributes( ) {
187+
stubFor(post(urlEqualTo("/"))
188+
.withHeader("x-amz-target", equalTo("AmazonSQS.GetQueueAttributes"))
189+
.willReturn(aResponse()
190+
.withStatus(200)
191+
.withBody(String.format(QUEUE_ATTRIBUTE_RESPONSE, "0", "30"))));
192+
}
193+
182194
private CompletableFuture<ReceiveMessageResponse> batchManagerReceiveMessage() {
183195
return receiveMessageBatchManager.receiveMessage(r -> r.queueUrl("test"));
184196
}

0 commit comments

Comments
 (0)