Skip to content

Commit 578bbd2

Browse files
corrected the getObject params in test:
1 parent 0d70dde commit 578bbd2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/presignedurl/DefaultPresignedUrlManagerTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ void given_PresignedUrlManager_when_GetObjectWithDifferentHttpResponses_then_Sho
165165
if (expectSuccess) {
166166
assertSuccessfulGetObject(testRequest);
167167
} else {
168-
assertThatThrownBy(() -> presignedUrlManager.getObject(testRequest))
168+
assertThatThrownBy(() -> presignedUrlManager.getObject(testRequest, ResponseTransformer.toInputStream()))
169169
.isInstanceOf(expectedExceptionType);
170170
}
171171
}
@@ -179,7 +179,7 @@ void given_PresignedUrlManager_when_GetObjectWithDifferentRequestConfigurations_
179179
PresignedUrlGetObjectRequest.Builder builder = PresignedUrlGetObjectRequest.builder();
180180
requestCustomizer.accept(builder);
181181
PresignedUrlGetObjectRequest request = builder.build();
182-
ResponseInputStream<GetObjectResponse> result = presignedUrlManager.getObject(request);
182+
ResponseInputStream<GetObjectResponse> result = presignedUrlManager.getObject(request, ResponseTransformer.toInputStream());
183183
assertThat(result).isNotNull();
184184
String content = IoUtils.toUtf8String(result);
185185
assertThat(content).isEqualTo(TEST_CONTENT);
@@ -223,7 +223,7 @@ void given_PresignedUrlManager_when_ExecutingDifferentScenarios_then_ShouldBehav
223223

224224
case "ENDPOINT_VERIFICATION":
225225
mockHttpClient.stubNextResponse(createSuccessResponse());
226-
presignedUrlManager.getObject(testRequest);
226+
presignedUrlManager.getObject(testRequest, ResponseTransformer.toInputStream());
227227
SdkHttpRequest lastRequest = mockHttpClient.getLastRequest();
228228
assertThat(lastRequest.getUri().toString()).startsWith(testPresignedUrl.toString().split("\\?")[0]);
229229
String presignedUrlQuery = testPresignedUrl.getQuery();
@@ -245,7 +245,7 @@ void given_PresignedUrlManager_when_ExecutingDifferentScenarios_then_ShouldBehav
245245
DefaultPresignedUrlManager managerWithMetrics = new DefaultPresignedUrlManager(
246246
clientHandler, protocolFactory, clientConfigWithMetrics, protocolMetadata);
247247
mockHttpClient.stubNextResponse(createSuccessResponse());
248-
managerWithMetrics.getObject(testRequest);
248+
managerWithMetrics.getObject(testRequest, ResponseTransformer.toInputStream());
249249
verify(mockPublisher, atLeastOnce()).publish(any(MetricCollection.class));
250250
ArgumentCaptor<MetricCollection> metricsCaptor = ArgumentCaptor.forClass(MetricCollection.class);
251251
verify(mockPublisher).publish(metricsCaptor.capture());
@@ -300,7 +300,7 @@ private static URL createTestUrl() {
300300

301301
private void assertSuccessfulGetObject(PresignedUrlGetObjectRequest request) {
302302
try {
303-
ResponseInputStream<GetObjectResponse> result = presignedUrlManager.getObject(request);
303+
ResponseInputStream<GetObjectResponse> result = presignedUrlManager.getObject(request, ResponseTransformer.toInputStream());
304304
assertThat(result).isNotNull();
305305
String content = IoUtils.toUtf8String(result);
306306
assertThat(content).isEqualTo(TEST_CONTENT);

0 commit comments

Comments
 (0)