Fixed an issue where using S3ClientConfiguration.Builder.endpointOverride could cause AWS_ERROR_INVALID_ARGUMENT. (#3315)

Author: millems

.changes/next-release/bugfix-AmazonS3TransferManager-37b38a2.json

@@ -0,0 +1,6 @@
+{
+    "type": "bugfix",
+    "category": "Amazon S3 Transfer Manager",
+    "contributor": "",
+    "description": "Fixed an issue where using S3ClientConfiguration.Builder.endpointOverride could cause AWS_ERROR_INVALID_ARGUMENT."
+}

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtAsyncHttpClient.java

@@ -91,8 +91,7 @@ public CompletableFuture<Void> execute(AsyncExecuteRequest asyncRequest) {
         S3MetaRequestOptions requestOptions = new S3MetaRequestOptions()
             .withHttpRequest(httpRequest)
             .withMetaRequestType(requestType)
-            .withResponseHandler(responseHandler)
-            .withEndpoint(s3NativeClientConfiguration.endpointOverride());
+            .withResponseHandler(responseHandler);
 
         try (S3MetaRequest s3MetaRequest = crtS3Client.makeMetaRequest(requestOptions)) {
             closeResourcesWhenComplete(executeFuture, s3MetaRequest, responseHandler);

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtAsyncHttpClientTest.java

@@ -84,7 +84,6 @@ public void defaultRequest_shouldSetMetaRequestOptionsCorrectly() {
         S3MetaRequestOptions actual = s3MetaRequestOptionsArgumentCaptor.getValue();
         assertThat(actual.getMetaRequestType()).isEqualTo(S3MetaRequestOptions.MetaRequestType.DEFAULT);
         assertThat(actual.getCredentialsProvider()).isNull();
-        assertThat(actual.getEndpoint().equals(DEFAULT_ENDPOINT));
 
         HttpRequest httpRequest = actual.getHttpRequest();
         assertThat(httpRequest.getEncodedPath()).isEqualTo("/key");