Skip to content

Commit 6a7f9ae

Browse files
committed
fix merge conflict resolution
1 parent 76cae1e commit 6a7f9ae

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/multipart/ParallelMultipartDownloaderSubscriber.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public class ParallelMultipartDownloaderSubscriber
114114
private final Map<Integer, CompletableFuture<GetObjectResponse>> inFlightRequests = new ConcurrentHashMap<>();
115115

116116
/**
117-
* Trasck the amount of in flight requests
117+
* Track the amount of in flight requests
118118
*/
119119
private final AtomicInteger inFlightRequestsNum = new AtomicInteger(0);
120120

@@ -221,9 +221,12 @@ public void onNext(AsyncResponseTransformer<GetObjectResponse, GetObjectResponse
221221
if (currentPartNum == 1) {
222222
sendFirstRequest(asyncResponseTransformer);
223223
} else {
224-
pendingTransformers.offer(Pair.of(currentPartNum, asyncResponseTransformer));
225224
totalPartsFuture.thenAccept(
226-
totalParts -> processingRequests(asyncResponseTransformer, currentPartNum, totalParts));
225+
totalParts -> {
226+
if (currentPartNum <= totalParts) {
227+
processingRequests(asyncResponseTransformer, currentPartNum, totalParts);
228+
}
229+
});
227230
}
228231
}
229232

@@ -258,7 +261,6 @@ private void sendNextRequest(AsyncResponseTransformer<GetObjectResponse, GetObje
258261

259262
CompletableFuture<GetObjectResponse> response = s3.getObject(request, asyncResponseTransformer);
260263

261-
inFlightRequestsNum.incrementAndGet();
262264
inFlightRequests.put(currentPartNumber, response);
263265
CompletableFutureUtils.forwardExceptionTo(resultFuture, response);
264266

@@ -272,7 +274,6 @@ private void sendNextRequest(AsyncResponseTransformer<GetObjectResponse, GetObje
272274
log.debug(() -> "Completed part: " + currentPartNumber);
273275

274276
inFlightRequests.remove(currentPartNumber);
275-
inFlightRequestsNum.decrementAndGet();
276277
completedParts.incrementAndGet();
277278
MultipartDownloadUtils.multipartDownloadResumeContext(getObjectRequest)
278279
.ifPresent(ctx -> ctx.addCompletedPart(currentPartNumber));

0 commit comments

Comments
 (0)