Skip to content

Commit 73fc9e9

Browse files
authored
Pin rewrite-maven-plugin version for migration test (#5708)
1 parent ab0f411 commit 73fc9e9

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

test/v2-migration-tests/src/test/java/software/amazon/awssdk/v2migrationtests/MavenProjectTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,8 @@
2929
import java.util.List;
3030
import org.apache.commons.io.FileUtils;
3131
import org.junit.jupiter.api.BeforeAll;
32-
import org.junit.jupiter.api.Disabled;
3332
import org.junit.jupiter.api.Test;
3433
import org.junit.jupiter.api.condition.EnabledIf;
35-
import software.amazon.awssdk.testutils.SdkVersionUtils;
3634
import software.amazon.awssdk.utils.Logger;
3735

3836
public class MavenProjectTest {
@@ -69,16 +67,17 @@ private static void deleteTempDirectories() throws IOException {
6967
}
7068

7169
@Test
72-
// @EnabledIf("versionAvailable")
73-
@Disabled("Test is flaky")
70+
@EnabledIf("versionAvailable")
7471
void mavenProject_shouldConvert() throws IOException {
7572
verifyTransformation();
7673
verifyCompilation();
7774
}
7875

7976
private static void verifyTransformation() throws IOException {
8077
List<String> rewriteArgs = new ArrayList<>();
81-
addAll(rewriteArgs, "mvn", "org.openrewrite.maven:rewrite-maven-plugin:run",
78+
// pin version since updates have broken tests
79+
String rewriteMavenPluginVersion = "5.43.0";
80+
addAll(rewriteArgs, "mvn", "org.openrewrite.maven:rewrite-maven-plugin:" + rewriteMavenPluginVersion + ":run",
8281
"-Drewrite.recipeArtifactCoordinates=software.amazon.awssdk:v2-migration:"+ getMigrationToolVersion() + "-PREVIEW",
8382
"-Drewrite.activeRecipes=software.amazon.awssdk.v2migration.AwsSdkJavaV1ToV2");
8483

0 commit comments

Comments
 (0)