Skip to content

Commit 76d2c0e

Browse files
committed
Fix generateDbConnectAdminAuthToken
1 parent 3a86352 commit 76d2c0e

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

services/dsql/src/main/java/software/amazon/awssdk/services/dsql/DsqlUtilities.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ default String generateDbConnectAuthToken(GenerateAuthTokenRequest request) {
8888
* @throws IllegalArgumentException if the required parameters are not valid
8989
*/
9090
default String generateDbConnectAdminAuthToken(Consumer<GenerateAuthTokenRequest.Builder> request) {
91-
return generateDbConnectAuthToken(GenerateAuthTokenRequest.builder().applyMutation(request).build());
91+
return generateDbConnectAdminAuthToken(GenerateAuthTokenRequest.builder().applyMutation(request).build());
9292
}
9393

9494
/**

services/dsql/src/test/java/software/amazon/awssdk/services/dsql/DefaultDsqlUtilitiesTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ public class DefaultDsqlUtilitiesTest {
3939
private static final String EXPECTED_TOKEN = "test.dsql.us-east-1.on.aws/?Action=DbConnect&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date"
4040
+ "=20241107T173933Z&X-Amz-SignedHeaders=host&X-Amz-Expires=900&X-Amz-Credential=access_key"
4141
+ "%2F20241107%2Fus-east-1%2Fdsql%2Faws4_request&X-Amz-Signature=e319d85380261f643d78a558f76257f05aacea758a6ccd42a2510e2ae0854a47";
42-
private static final String EXPECTED_ADMIN_TOKEN = "test.dsql.us-east-1.on.aws/?Action=DbConnect&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date="
43-
+ "20241107T173933Z&X-Amz-SignedHeaders=host&X-Amz-Expires=900&X-Amz-Credential=access_key"
44-
+ "%2F20241107%2Fus-east-1%2Fdsql%2Faws4_request&X-Amz-Signature=e319d85380261f643d78a558f76257f05aacea758a6ccd42a2510e2ae0854a47";
42+
private static final String EXPECTED_ADMIN_TOKEN = "test.dsql.us-east-1.on.aws/?Action=DbConnectAdmin&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date"
43+
+ "=20241107T173933Z&X-Amz-SignedHeaders=host&X-Amz-Expires=900&X-Amz-Credential=access_key"
44+
+ "%2F20241107%2Fus-east-1%2Fdsql%2Faws4_request&X-Amz-Signature=a08adc4c84a490014ce374b90c98ba9ed015b77b451c0d9f9fb3f8ca8c6f9c36";
4545

4646
@Test
4747
public void tokenGenerationWithBuilderDefaultsUsingAwsCredentialsProvider_isSuccessful() {
@@ -110,7 +110,7 @@ private void tokenGenerationWithOverriddenCredentials(DsqlUtilities.Builder buil
110110
String authToken = dsqlUtilities.generateDbConnectAuthToken(b -> b.hostname(HOSTNAME).applyMutation(credsBuilder));
111111
assertThat(authToken).isEqualTo(EXPECTED_TOKEN);
112112

113-
String adminAuthToken = dsqlUtilities.generateDbConnectAuthToken(b -> b.hostname(HOSTNAME).applyMutation(credsBuilder));
113+
String adminAuthToken = dsqlUtilities.generateDbConnectAdminAuthToken(b -> b.hostname(HOSTNAME).applyMutation(credsBuilder));
114114
assertThat(adminAuthToken).isEqualTo(EXPECTED_ADMIN_TOKEN);
115115
}
116116

@@ -204,10 +204,10 @@ public void tokenGenerationWithCustomExpiry_isSuccessful() {
204204
+ "%2F20241107%2Fus-east-1%2Fdsql%2Faws4_request&X-Amz-Signature=63987ab6908fe81bfcaa5a5120444a8d012751992bcdfec351522db555232c51";
205205
assertThat(authToken).isEqualTo(expectedToken);
206206

207-
String adminAuthToken = utilities.generateDbConnectAuthToken(b -> b.hostname(HOSTNAME).expiresIn(expiry));
208-
String expectedAdminToken = "test.dsql.us-east-1.on.aws/?Action=DbConnect&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date="
207+
String adminAuthToken = utilities.generateDbConnectAdminAuthToken(b -> b.hostname(HOSTNAME).expiresIn(expiry));
208+
String expectedAdminToken = "test.dsql.us-east-1.on.aws/?Action=DbConnectAdmin&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date="
209209
+ "20241107T173933Z&X-Amz-SignedHeaders=host&X-Amz-Expires=3600&X-Amz-Credential=access_key"
210-
+ "%2F20241107%2Fus-east-1%2Fdsql%2Faws4_request&X-Amz-Signature=63987ab6908fe81bfcaa5a5120444a8d012751992bcdfec351522db555232c51";
210+
+ "%2F20241107%2Fus-east-1%2Fdsql%2Faws4_request&X-Amz-Signature=46e02dfc8d6d07289b9e5910ccd9a50f1c3b798e48ccd92153255df508bd0b82";
211211
assertThat(adminAuthToken).isEqualTo(expectedAdminToken);
212212
}
213213
}

0 commit comments

Comments
 (0)